remove some refs in TraversableOnce#8732
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Feb 27, 2020
Merged
Conversation
4a1c47b to
d2711cb
Compare
d2711cb to
501533a
Compare
retronym
approved these changes
Feb 25, 2020
Member
retronym
left a comment
There was a problem hiding this comment.
Would be neat if we could teach the optimizer to do this but it would be a serious job.
Back here in the real world, this LGTM.
Separately, it might also be worthwhile overriding the most commonly used ones of these in the most commonly used collections (forSome { "common" }). This could extract further performance gains by:
- avoiding the lambda allocation altogether
- avoiding the virtual call from, e.g.
List.foreachtocounter.applyinside the loop
Member
|
this caused a community build regression; see scala/scala-dev#673 |
SethTisue
added a commit
to SethTisue/scala
that referenced
this pull request
Feb 29, 2020
SethTisue
added a commit
to SethTisue/scala
that referenced
this pull request
Feb 29, 2020
Member
|
#8769 has the partial reversion |
SethTisue
added a commit
that referenced
this pull request
Feb 29, 2020
[nomerge] partially revert #8732 to remove problematic isEmpty checks
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
…Traversable remove some refs in TraversableOnce
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
[nomerge] partially revert scala/scala#8732 to remove problematic isEmpty checks
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
…Traversable remove some refs in TraversableOnce
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
May 7, 2025
[nomerge] partially revert scala/scala#8732 to remove problematic isEmpty checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.