Skip to content

Bump Xmx for type-tag-leak#8546

Merged
retronym merged 1 commit intoscala:2.13.xfrom
lrytz:type-tag-leak-bump
Nov 19, 2019
Merged

Bump Xmx for type-tag-leak#8546
retronym merged 1 commit intoscala:2.13.xfrom
lrytz:type-tag-leak-bump

Conversation

@lrytz
Copy link
Member

@lrytz lrytz commented Nov 18, 2019

The test allocates 16*16 MB, so testing with a 192 MB heap should
be safe to catch the leak.

Tested with running the test in a while true loop locally

  • constanly fails with 192 MB on 2.13.1
  • constantly succeeds with 192 MB on 2.13.2-bin-9ef8fc3
  • flaky with 128 MB on 2.13.2-bin-9ef8fc3

Showed up in #8537, #8538, #8539, #8540

@lrytz
Bump Xmx for type-tag-leak
ffcffc6 
The test allocates 16*16 MB, so testing with a 192 MB heap should
be safe to catch the leak.

Tested with running the test in a `while true` loop locally
  - constanly fails with 192 MB on 2.13.1
  - constantly succeeds with 192 MB on 2.13.2-bin-9ef8fc3
  - flaky with 128 MB on 2.13.2-bin-9ef8fc3
@lrytz lrytz requested a review from retronym November 18, 2019 14:29
@scala-jenkins scala-jenkins added this to the 2.13.2 milestone Nov 18, 2019
@diesalbla diesalbla added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Nov 18, 2019
@retronym retronym merged commit c531129 into scala:2.13.x Nov 19, 2019
@SethTisue
Copy link
Member

SethTisue commented Dec 9, 2019 •
edited
Loading

@lrytz @retronym I'm seeing occasional type-tag-leak failures at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-windows/

for example https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-windows/1575/ has

!! 1908 - run/type-tag-leak.scala                   [non-zero exit code][duration 23.55s]
##### Log file 'Y:\jenkins\workspace\scala-2.12.x-integrate-windows\test\files\run\type-tag-leak-run.log' from failed test #####

Terminating due to java.lang.OutOfMemoryError: Java heap space
Picked up _JAVA_OPTIONS: -Duser.home=y:/jenkins -Djava.io.tmpdir=y:/jenkins/tmp -Dhudson.remoting.RemoteClassLoader.force=com.sun.jna.Native

@SethTisue SethTisue mentioned this pull request Dec 9, 2019
Merged
@lrytz
Copy link
Member Author

lrytz commented Dec 9, 2019

Bump it a bit further? Or skip on Windows? The additional Windows test doesn't improve coverage for the type tag leak fix, it just tests the JVM on Windows.

@retronym
Copy link
Member

retronym commented Dec 9, 2019 •
edited
Loading

This change just needs a backport to 2.12.x, I'll do that today.

@lrytz
Copy link
Member Author

lrytz commented Dec 10, 2019

👍 I didn't realize it's 2.12.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retronym retronym retronym approved these changes

Assignees

No one assigned

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Milestone

2.13.2

Development

Successfully merging this pull request may close these issues.

5 participants

@lrytz @SethTisue @retronym @scala-jenkins @diesalbla