Dealias chain all the things when looking for Any by som-snytt · Pull Request #8538 · scala/scala

som-snytt · 2019-11-12T19:48:27Z

When examining trees for explicit top types,
look at all aliases.

Fixes scala/bug#11798

hrhino · 2019-11-12T20:16:45Z

Your secret identity is showing.

som-snytt · 2019-11-12T20:40:43Z

I must be committing from my smart phone.

When examining trees for explicit top types, look at all aliases.

som-snytt · 2019-11-12T23:42:56Z

I, too, broke the new type-tag-leak test.

som-snytt · 2019-11-14T17:14:38Z

I wonder if @hrhino the sharp-eyed one is willing to visually verify this quick fix. Ignoring the spurious travis failure, of course.

Every Scala 2 change is either too big to push through, or too trivial to be worth a PR. And my lunch breaks are finitely bounded.

adamgfraser · 2019-11-19T12:06:43Z

Fantastic! Thank you so much!

SethTisue · 2019-11-22T05:16:54Z

Cleanup in aisle #nogooddeedgoesunpunished

This caused a regression in the 2.13 community build, compiling Akka. I identified the culprit PR using git bisect. ("Culprit", such a harsh word. Perhaps "our next contestant"?)

https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/2819/artifact/logs/akka-stream-build.log

[error] java.lang.StackOverflowError
[error] 	at scala.tools.nsc.typechecker.Infer$Inferencer$$anon$1.super$apply(Infer.scala:591)
[error] 	at scala.tools.nsc.typechecker.Infer$Inferencer$$anon$1.$anonfun$apply$1(Infer.scala:591)
[error] 	at scala.tools.nsc.typechecker.Infer$Inferencer$$anon$1.apply(Infer.scala:591)
[error] 	at scala.reflect.internal.Types$TypeRef.foldOver(Types.scala:2373)
[error] 	at scala.reflect.internal.tpe.TypeMaps$ExistsTypeRefCollector.apply(TypeMaps.scala:1043)
[error] 	at scala.tools.nsc.typechecker.Infer$Inferencer$$anon$1.super$apply(Infer.scala:591)
[error] 	at scala.tools.nsc.typechecker.Infer$Inferencer$$anon$1.$anonfun$apply$1(Infer.scala:591)
...

the problem is reproducible on the 2.13.x branch of scala/community-build with ./narrow akka-stream followed by ./run.sh

it's also reproducible outside of dbuild with:

hub clone akka/akka
cd akka
git checkout release-2.5

then:

diff --git project/AkkaDisciplinePlugin.scala project/AkkaDisciplinePlugin.scala
index 84d4db8ff4..3146b40427 100644
--- project/AkkaDisciplinePlugin.scala
+++ project/AkkaDisciplinePlugin.scala
@@ -43,11 +43,11 @@ object AkkaDisciplinePlugin extends AutoPlugin with ScalafixSupport {
     })
 
   lazy val silencerSettings = {
-    val silencerVersion = "1.4.1"
+    val silencerVersion = "1.4.4"
     Seq(
       libraryDependencies ++= Seq(
-          compilerPlugin("com.github.ghik" %% "silencer-plugin" % silencerVersion),
-          "com.github.ghik" %% "silencer-lib" % silencerVersion % Provided))
+          compilerPlugin("com.github.ghik" % "silencer-plugin_2.13.1" % silencerVersion),
+          "com.github.ghik" % "silencer-lib_2.13.1" % silencerVersion % Provided))
   }

and:

sbt
++2.13.2-bin-9af26f8!
akka-stream/compile

som-snytt · 2019-11-22T05:41:13Z

I was just saying how nice it is when people complain you broke something, because it means what you do really matters.

Noting here that Lukas asked for a performance check; and previously Jason has asked that all this type tracking or double-checking be rewritten.

I'll add this to my post-it note. Let me know if you'd like a quick reversion, or wait a bit to see if anything shakes out. I'm wondering if the check can be deferred until the end of typers via that deferred work queue.

SethTisue · 2019-11-22T05:51:08Z

2.13.2 isn't imminent, and 150 projects remain green in the community build, so I don't think a quick reversion is necessary.

som-snytt · 2019-11-23T19:05:41Z

Instead, I got:

[info] Out of 1 candidates we found for org.scala-lang#scala-compiler;2.13.2-bin-767bd9f-SNAPSHOT in local, we are choosing local.
[info] Done updating.
[info] Formatting 22 Java sources ProjectRef(uri("file:/home/amarki/projects/akka/"), "akka-actor")(compile) ...
[info] Generating 'Functions.scala'
[info] Generating 'Tuples.scala'
[error] java.util.NoSuchElementException: key not found: 8
[error]         at scala.collection.immutable.Map$EmptyMap$.apply(Map.scala:98)
[error]         at scala.collection.immutable.Map$EmptyMap$.apply(Map.scala:96)
[error]         at akka.AkkaBuild$.$anonfun$defaultSettings$6(AkkaBuild.scala:146)
[error]         at scala.Function1.$anonfun$compose$1(Function1.scala:44)
[error]         at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:40)
[error]         at sbt.std.Transform$$anon$4.work(System.scala:67)
[error]         at sbt.Execute.$anonfun$submit$2(Execute.scala:269)
[error]         at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:16)
[error]         at sbt.Execute.work(Execute.scala:278)
[error]         at sbt.Execute.$anonfun$submit$1(Execute.scala:269)
[error]         at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)
[error]         at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
[error]         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]         at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
[error]         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]         at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[error]         at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[error]         at java.base/java.lang.Thread.run(Thread.java:834)

Trying just root compile now. Actually that eventually fails.

SethTisue · 2019-11-27T23:38:56Z

that eventually fails

eventually fails with SOE, so you're good to proceed?
or eventually fails with NSE, and you need help testing a prospective fix?

som-snytt · 2019-11-27T23:58:25Z

I wasn't able to build independently to diagnose the failure. I hadn't entirely given up yet, akka happens to be cloned on my other machine.

SethTisue · 2019-12-02T22:35:00Z

above I said hub clone akka/akka; cd akka; git checkout release-2.5 but that branch has moved on a bit. the above instructions still apply except that the build patch is a bit different:

--- project/AkkaDisciplinePlugin.scala
+++ project/AkkaDisciplinePlugin.scala
@@ -46,8 +46,8 @@ object AkkaDisciplinePlugin extends AutoPlugin with ScalafixSupport {
     val silencerVersion = "1.4.4"
     Seq(
       libraryDependencies ++= Seq(
-          compilerPlugin(("com.github.ghik" %% "silencer-plugin" % silencerVersion).cross(CrossVersion.patch)),
-          ("com.github.ghik" %% "silencer-lib" % silencerVersion % Provided).cross(CrossVersion.patch)))
+          compilerPlugin(("com.github.ghik" % "silencer-plugin_2.13.1" % silencerVersion)),
+          ("com.github.ghik" % "silencer-lib_2.13.1" % silencerVersion % Provided)))

this is at dfedb66e24ff196888e987a6183c514857a83078, so you might git checkout dfedb66e24ff1968 instead of git checkout release-2.5

in the 2.13 community build, I temporarily reverted to an older Scala SHA until we can get this sorted out. let me know if I can be of any other assistance (up to and including "I don't have time for this at present, can someone at Lightbend take it over?")

som-snytt · 2019-12-03T06:28:53Z

I was able to reproduce under Ubuntu instead of Ubuntu under windoze.

akka.stream.impl.SetupStage has a refinement type which causes the loopy recursion when folding over it. Just skipping refinement types avoids that, so I'll PR that. My first attempt to minimize the test didn't reproduce it.

SethTisue · 2019-12-10T01:09:05Z

fixed in #8577

scala-jenkins added this to the 2.13.2 milestone Nov 12, 2019

Dealias chain all the things when looking for Any

b901802

When examining trees for explicit top types, look at all aliases.

som-snytt force-pushed the issue/11798-infer-any branch from be5941c to b901802 Compare November 12, 2019 20:46

som-snytt mentioned this pull request Nov 13, 2019

Less yammering, more hammering: fix two broken windows tests #8539

Merged

som-snytt requested a review from hrhino November 14, 2019 17:14

lrytz mentioned this pull request Nov 18, 2019

Bump Xmx for type-tag-leak #8546

Merged

lrytz approved these changes Nov 19, 2019

View reviewed changes

lrytz merged commit 9af26f8 into scala:2.13.x Nov 19, 2019

som-snytt deleted the issue/11798-infer-any branch November 19, 2019 12:55

SethTisue mentioned this pull request Nov 27, 2019

2.13: move to Akka 2.6, Play 2.8, Lagom 1.6 scala/community-build#1008

Merged

som-snytt mentioned this pull request Dec 5, 2019

Warn infer-any avoids extra work #8577

Merged

Conversation

som-snytt commented Nov 12, 2019

Uh oh!

hrhino commented Nov 12, 2019

Uh oh!

som-snytt commented Nov 12, 2019

Uh oh!

som-snytt commented Nov 12, 2019

Uh oh!

som-snytt commented Nov 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamgfraser commented Nov 19, 2019

Uh oh!

SethTisue commented Nov 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

som-snytt commented Nov 22, 2019

Uh oh!

SethTisue commented Nov 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

som-snytt commented Nov 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SethTisue commented Nov 27, 2019

Uh oh!

som-snytt commented Nov 27, 2019

Uh oh!

SethTisue commented Dec 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

som-snytt commented Dec 3, 2019

Uh oh!

SethTisue commented Dec 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

som-snytt commented Nov 14, 2019 •

edited

Loading

SethTisue commented Nov 22, 2019 •

edited

Loading

SethTisue commented Nov 22, 2019 •

edited

Loading

som-snytt commented Nov 23, 2019 •

edited

Loading

SethTisue commented Dec 2, 2019 •

edited

Loading