Emit mixin forwarders as ordinary, non-bridge methods again#8037
Merged
lrytz merged 7 commits intoscala:2.13.xfrom May 7, 2019
Merged
Emit mixin forwarders as ordinary, non-bridge methods again#8037lrytz merged 7 commits intoscala:2.13.xfrom
lrytz merged 7 commits intoscala:2.13.xfrom
Conversation
86248e9 to
1b26e0b
Compare
…natures" This reverts commit 3e1f47d.
1b26e0b to
f8c0034
Compare
Member
Thanks for letting me know. This is not an issue for Scala.js, as anyway we fixed the original Scala.js thing in scala-js/scala-js#3584 for earlier versions of Scala. That fix will work equally well for 2.13.x with the present PR merged. |
lrytz
added a commit
that referenced
this pull request
May 7, 2019
sjrd
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 5, 2024
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
sjrd
added a commit
to dotty-staging/dotty
that referenced
this pull request
Feb 25, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
sjrd
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 30, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
jchyb
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 14, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
hamzaremmal
added a commit
to scala/scala3
that referenced
this pull request
Jul 27, 2025
Forward port of scala/scala#8037 Reverts #6352 and #6141. Fixes #19270.
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 17, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 17, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 17, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 17, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
Sep 17, 2025
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7980 and #7843, as discussed on scala/bug#11512.
Fixes scala/bug#11484, fixes scala/bug#11512.
Reopens scala/bug#8905.
cc @sjrd.