Add java varargs forwarders to mirror classes#7017
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Aug 16, 2018
Merged
Conversation
They were accidentally dropped in scala#6531. Fixes scala/bug#11057.
Contributor
|
@lrytz can you add this test to prevent further regressions: MasseGuillaume@d6f71e7 ? |
Member
Author
|
I updated test/files/jvm/varargs instead as regression test |
Contributor
|
Ahh I see, it's only because it comes from an object that the bytecode is not generated. |
Member
|
@retronym would be good to get this merged if we can, since it's blocking Akka on 2.13 |
eed3si9n
added a commit
to eed3si9n/scala
that referenced
this pull request
Aug 11, 2018
Member
|
ping @retronym |
retronym
approved these changes
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were accidentally dropped in #6531.
Fixes scala/bug#11057.