Handle unrelatable skolems in TypeVar bounds#6421
Merged
adriaanm merged 1 commit intoscala:2.13.xfrom Aug 9, 2018
Merged
Conversation
5950659 to
c104144
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
😮Impressive! I will try to review before Scala Days, but lots of stuff going on :-/ |
Member
Author
|
Does this make sense without #6257 🤔 |
by existentially abstracting them. Adds a necessary boolean flag to `existentialAbstraction` to flip the variance for upper bounds which need to be minimized. Fixes scala/bug#5559, fixes scala/bug#5579, fixes scala/bug#10519 and fixes scala/bug#10771
c104144 to
69dd610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by existentially abstracting them.
Adds a necessary boolean flag to
existentialAbstractionto flipthe variance for upper bounds which need to be minimized.
Fixes scala/bug#5559, fixes scala/bug#5579, fixes scala/bug#10519
and fixes scala/bug#10771
Depends on #6257