Fix for SI-9881 in branch 2.11.x#6195
Conversation
|
Not sure what causes the failure: "combined — Found earlier commit(s) marked failure: 68118b"... |
|
Jenkins, re-test this please. |
|
/rebuild |
|
It seems that |
|
yeah, looks like a Scabot limitation. we can just |
|
note that in general, we're no longer accepting changes for 2.11.x and there are currently no plans for a 2.11.13 release. you might able to persuade @adriaanm, but you'd probably need to explicitly make a case that this is both sufficiently critical and sufficiently safe |
|
Hi, thanks for the info. The bug does not seem to be critical (marked as minor in Jira), so I don't think we should make too much effort to merge/release this one. |
|
I would be open to a 2.11 release dedicated to fixing bugs that affect Spark (at least a half dozen, to make it worth cutting a release), if someone is willing to step up and coordinate the work. We can't afford to invest in 2.11 anymore, but I won't stand in the way of progress :-) (Wellllll, ideally, the progress would be for Spark to upgrade to 2.12 ;-)) Regarding this bug: the workaround of turning of the class based encoding is unlikely to work because I think Spark relies on it for improved serialization or lower memory retention? |
|
Hi @adriaanm,
Based on this list, I find it highly unprobable to collect the number of changes that would warrant a 2.11 release. |
|
As discussed above, it does not seem practical to plan a release for these changes. |
|
Thanks for digging in, @mpetruska! We are still considering another 2.11 with some other small fixes, so we could try to tackle at least a few of the spark shell issues that have a low chance of causing regressions. Track scala/scala-dev#451 for the planning around it. I expect a release either late this year or beginning of January. |
|
Re-opening to allow tracking the changes in scala/scala-dev#451. |
…lass constructors, extends clause ## What changes were proposed in this pull request? [SPARK-22393](https://issues.apache.org/jira/browse/SPARK-22393) ## How was this patch tested? With a new test case in `RepSuite` ---- This code is a retrofit of the Scala [SI-9881](scala/bug#9881) bug fix, which never made it into the Scala 2.11 branches. Pushing these changes directly to the Scala repo is not practical (see: scala/scala#6195). Author: Mark Petruska <petruska.mark@gmail.com> Closes #19846 from mpetruska/SPARK-22393.
|
labeling as WIP so it doesn't show up when filter on that label's absence |
2.11 fix for scala/bug#9881
89150d0 to
a97cefd
Compare
|
Tested locally. TODO: bring back CI for 2.11.x if we're going to do cut another release. |
|
this is failing on Windows at https://scala-ci.typesafe.com/view/scala-2.11.x/job/scala-2.11.x-integrate-windows/ |
|
Is … is this complaining about white space (maybe Windows line-ending issue)? |
|
very likely Windows line endings |
|
attempting a fix over at #6777 |
Retrofits fix for SI-9881 to branch 2.11.x. Contains the changes of #5640 .
This change should fix Spark issue 22393