SD-186 Fix positions in trait method bytecode#5296
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Jul 22, 2016
Merged
Conversation
Member
Author
Concrete, non private methods in traits are translated into a static method with an explicit `$this` parameter. After this translation, the references to `$this` (subistuted for `this` in user written code) where being positioned at the position of the method, which makes debugging unpleasant. This commit leaves the `Ident($this)` trees unpositioned. This is analagous to what we do in the body of extension methods, which is the other user of `ThisSubstitutor`. It would be more correct to copy the position of each `This` tree over to the substituted tree. That would let us set a breakpoint on a line that _only_ contained `this`. But in 99% of cases users won't be able to spot the difference, so I've opted for the tried and tested approach here.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concrete, non private methods in traits are translated into a static
method with an explicit
$thisparameter. After this translation,the references to
$this(subistuted forthisin user written code)where being positioned at the position of the method, which makes
debugging unpleasant.
This commit leaves the
Ident($this)trees unpositioned. This isanalagous to what we do in the body of extension methods, which
is the other user of
ThisSubstitutor.It would be more correct to copy the position of each
Thistree over to the substituted tree. That would let us set a breakpoint
on a line that only contained
this. But in 99% of cases userswon't be able to spot the difference, so I've opted for the tried
and tested approach here.
Review by @lrytz