SI-9534 Use BoxedUnit in all cases for creating Array[Unit]#4921
Merged
retronym merged 1 commit intoscala:2.11.xfrom Feb 1, 2016
Merged
SI-9534 Use BoxedUnit in all cases for creating Array[Unit]#4921retronym merged 1 commit intoscala:2.11.xfrom
retronym merged 1 commit intoscala:2.11.xfrom
Conversation
Calling `wrap` or one of the higher-dimension Array factory methods on the `Manifest` for `Unit` led to an exception because it tried to use `void` as a primitive type. Unlike all other primitive Scala types, `Unit` needs to be boxed. The basic `newArray` method was not affected by this bug because it was already special-cased. The fix is to also special-case `arrayClass`.
Contributor
|
Thanks Stefan! |
Member
|
LGTM |
retronym
added a commit
that referenced
this pull request
Feb 1, 2016
SI-9534 Use BoxedUnit in all cases for creating Array[Unit]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
wrapor one of the higher-dimension Array factory methods onthe
ManifestforUnitled to an exception because it tried to usevoidas a primitive type. Unlike all other primitive Scala types,Unitneeds to be boxed. The basicnewArraymethod was not affectedby this bug because it was already special-cased. The fix is to also
special-case
arrayClass.