Skip to content

Apply title case to Scaladoc buttons: By Inheritance & Show All#4883

Merged
SethTisue merged 1 commit intoscala:2.11.xfrom
janekdb:2.11-x-scaladoc-ui-capitalization
Dec 16, 2015
Merged

Apply title case to Scaladoc buttons: By Inheritance & Show All#4883
SethTisue merged 1 commit intoscala:2.11.xfrom
janekdb:2.11-x-scaladoc-ui-capitalization

Conversation

@janekdb
Copy link
Member

@janekdb janekdb commented Dec 15, 2015

The alternative choice was to change "Hide All" to "Hide all" to match the majority capitalization but title case fits for this UI.

image

The alternative choice was to change "Hide All" to "Hide all" to match existing
capitalization but title case fits for this UI.
@scala-jenkins scala-jenkins added this to the 2.11.8 milestone Dec 15, 2015
@janekdb
Copy link
Member Author

janekdb commented Dec 15, 2015

Review by @heathermiller, @felixmulder.

@felixmulder
Copy link
Contributor

👍

@heathermiller
Copy link
Member

LGTM :)

@SethTisue
Copy link
Member

integrate-ide failure is unrelated

SethTisue added a commit that referenced this pull request Dec 16, 2015
Apply title case to Scaladoc buttons: By Inheritance & Show All
@SethTisue SethTisue merged commit 39f22b9 into scala:2.11.x Dec 16, 2015
@SethTisue
Copy link
Member

thanks Janek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants