Skip to content

Document JavaConverters conversion from java.util.Properties to Map#4882

Merged
lrytz merged 1 commit intoscala:2.11.xfrom
janekdb:2.11.x-scaladoc-tables-1
Dec 18, 2015
Merged

Document JavaConverters conversion from java.util.Properties to Map#4882
lrytz merged 1 commit intoscala:2.11.xfrom
janekdb:2.11.x-scaladoc-tables-1

Conversation

@janekdb
Copy link
Member

@janekdb janekdb commented Dec 12, 2015

Also

  • Fix grammar on duplicated DecorateAsJava comment by copying over from
    JavaConverters
  • Remove author tags

@scala-jenkins scala-jenkins added this to the 2.11.8 milestone Dec 12, 2015
@janekdb
Copy link
Member Author

janekdb commented Dec 12, 2015

An alternative approach is to delete the comment on DecorateAsJava.

@janekdb
Copy link
Member Author

janekdb commented Dec 12, 2015

Review by @dickwall, @heathermiller, @som-snytt.

@janekdb
Copy link
Member Author

janekdb commented Dec 12, 2015

Failed with,

[ERROR]
    /home/jenkins/workspace/scala-2.11.x-integrate-ide/target/scala-ide/org.scala-ide.sdt.core/
    src/org/scalaide/extensions/CompilerSupport.scala:98: error: value samePos is not a member
    of RichCompilationUnits.this.Tree
[ERROR]
    compilationUnitOfFile(file) exists (_.body.samePos(tree.pos))

@janekdb janekdb force-pushed the 2.11.x-scaladoc-tables-1 branch from 746fe6d to 821260b Compare December 12, 2015 20:42
@janekdb janekdb changed the title Fix grammar on duplicated DecorateAsJava comment Document JavaConverters conversion from java.util.Properties to Map Dec 12, 2015
janekdb
janekdb reviewed Dec 12, 2015
View reviewed changes
src/library/scala/collection/convert/DecorateAsJava.scala
Copy link
Member Author

@janekdb janekdb Dec 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DecorateAsJava does not contain this but it doesn't contain any asScala methods even though line 20 notes that it does. More evidence this comment should be deleted.

@janekdb
Document JavaConverters conversion from java.util.Properties to Map
2319844 
Also

 - Fix grammar on duplicated DecorateAsJava comment by copying over from
   JavaConverters
 - Remove author tags
@janekdb janekdb force-pushed the 2.11.x-scaladoc-tables-1 branch from 821260b to 2319844 Compare December 12, 2015 20:47
@SethTisue
Copy link
Member

SethTisue commented Dec 16, 2015

LGTM

lrytz added a commit that referenced this pull request Dec 18, 2015
@lrytz
Merge pull request #4882 from janekdb/2.11.x-scaladoc-tables-1
b50d58c 
Document JavaConverters conversion from java.util.Properties to Map
@lrytz lrytz merged commit b50d58c into scala:2.11.x Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.11.8

Development

Successfully merging this pull request may close these issues.

4 participants

@janekdb @SethTisue @lrytz @scala-jenkins