Merged
Conversation
It's useful to know that log is the natural logarithm, not 10log or 2log or so. Also did sqrt "while I was at it"
src/library/scala/math/package.scala
Outdated
Contributor
There was a problem hiding this comment.
Do we really need this line? If you're using logarithms and you don't know what a natural logarithm is, I think there's already a problem. (And I doubt that Euler's number will help anything.)
Member
|
@martijnhoekstra do you want to make any further changes based on @Ichoran's feedback? |
Contributor
Author
|
Thanks for pinging. I took another stab. |
Member
|
LGTM. thank you Martin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's useful to know that log is the natural logarithm, not 10log or 2log or so.
Also did sqrt "while I was at it"