Conversation
|
Not sure if the script is general/useful enough to be committed as well? Will look in the failure tomorrow morning. |
|
I'm at a loss... This is the test that's failing: https://github.com/scala-ide/scala-ide/blob/master/org.scala-ide.sdt.debug.expression.tests/src/org/scalaide/debug/internal/expression/features/NewKeywordTest.scala#L55 How can changes to documentation and type parameter names break this test? |
|
Maybe the IDE failure is just a flaky test. But you are not allowed to just change the parameter names of a function, since they could be called from within user code. At least, you have to annotate them with |
|
the changes are good, but we need to revert the parameter name changes. also, i'm not sure about merging this because it fixes only a part of the collection doc (methods a-f) and nobody seems seems to be doing the rest.. @SethTisue what do you think? |
|
I keep hoping someone will magically appear and volunteer to finish it. @janekdb, maybe this one would interest you...? |
|
@SethTisue - Thanks for flagging this one up. I'll spend sometime to see how I can best contribute! |
I've created a PR I own to allow me to push, following the guidelines here: https://help.github.com/articles/checking-out-pull-requests-locally/ Kindly let me know if there was a better way of approaching this. |
This is fine. (An alternative would have been to ask @vsalvis for push access to their fork.) |
Some doc fixes for GenTraversableOnce, methods from aggregate to foreach in alphabetical order. I'm leaving EPFL, so somebody else will have to do the rest of the alphabet ;)
Types of corrections: