remove legacy bincompat stuff in two places#4640
Merged
SethTisue merged 1 commit intoscala:2.12.xfrom Jul 21, 2015
Merged
Conversation
Member
Author
|
review by @lrytz |
Member
|
LGTM. Could have been a single commit for me :) |
Member
Author
|
https://scala-ci.typesafe.com/job/scala-2.12.x-validate-test/224/console shows: This is because the binary incompatible change to Stream broke the partest we're using. As discussed with @lrytz, the fix steps are:
|
SethTisue
added a commit
to SethTisue/scala-partest
that referenced
this pull request
Jul 20, 2015
see scala/scala#4640 for details. in that PR (targeted for 2.12.0-M3), we are making a binary incompatible change to Stream. by avoiding using Stream at all here, we avoid running afoul of the incompatibility. Stream is arguably overkill here anyway, Iterator is just fine. so there's no need to change the code back after we're over the M2/M3 incompatibility hump.
8195b96 to
b904e15
Compare
it was only there to preserve binary compatibility within the 2.11.x series includes updated partest, since the old partest ran afoul of the Stream change
b904e15 to
1408162
Compare
SethTisue
added a commit
that referenced
this pull request
Jul 21, 2015
remove legacy bincompat stuff in two places
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
see scala/scala#4640 for details. in that PR (targeted for 2.12.0-M3), we are making a binary incompatible change to Stream. by avoiding using Stream at all here, we avoid running afoul of the incompatibility. Stream is arguably overkill here anyway, Iterator is just fine. so there's no need to change the code back after we're over the M2/M3 incompatibility hump.
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
see scala/scala#4640 for details. in that PR (targeted for 2.12.0-M3), we are making a binary incompatible change to Stream. by avoiding using Stream at all here, we avoid running afoul of the incompatibility. Stream is arguably overkill here anyway, Iterator is just fine. so there's no need to change the code back after we're over the M2/M3 incompatibility hump.
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
May 9, 2018
see scala#4640 for details. in that PR (targeted for 2.12.0-M3), we are making a binary incompatible change to Stream. by avoiding using Stream at all here, we avoid running afoul of the incompatibility. Stream is arguably overkill here anyway, Iterator is just fine. so there's no need to change the code back after we're over the M2/M3 incompatibility hump.
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
May 9, 2018
see scala#4640 for details. in that PR (targeted for 2.12.0-M3), we are making a binary incompatible change to Stream. by avoiding using Stream at all here, we avoid running afoul of the incompatibility. Stream is arguably overkill here anyway, Iterator is just fine. so there's no need to change the code back after we're over the M2/M3 incompatibility hump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.