Skip to content

Derive repository info from (jenkins) env vars#4453

Merged
adriaanm merged 1 commit intoscala:2.11.xfrom
adriaanm:repo-config-no-dup
Apr 16, 2015
Merged

Derive repository info from (jenkins) env vars#4453
adriaanm merged 1 commit intoscala:2.11.xfrom
adriaanm:repo-config-no-dup

Conversation

@adriaanm
Copy link
Contributor

No description provided.

@scala-jenkins scala-jenkins added this to the 2.11.7 milestone Apr 16, 2015
@retronym
Copy link
Member

Two minor comments:

  • Could you extract a variable for $scriptsDir/repositories-scala-release and refer to it in sbtArgs=? That will make the data dependencies between the steps in the script more obvious.
  • Given that this is pretty esotoric SBT config, add a link the relevant SBT docs: http://www.scala-sbt.org/0.13/docs/Proxy-Repositories.html and explain the intent ("PR valiadation uses a dedicated repostory to share artifcacts between jobs, so we need to configure SBT to use these rather than its default, Maven Central")

Otherwise LGTM. Great to see we'll be able to handle the bintray switch a relatively low cost.

Since we're moving to bintray, first centralizing the config of
the repositories we use while bootstrapping a release.

This should not be hardcoded in scala/scala anyway, it's an
implementation detail of our infrastructure, which is defined by
scala/scala-jenkins-infra.
@adriaanm adriaanm force-pushed the repo-config-no-dup branch from 2ebaf19 to e0bec87 Compare April 16, 2015 23:12
@adriaanm
Copy link
Contributor Author

Amended.

adriaanm added a commit that referenced this pull request Apr 16, 2015
Derive repository info from (jenkins) env vars
@adriaanm adriaanm merged commit 64685a2 into scala:2.11.x Apr 16, 2015
@adriaanm adriaanm deleted the repo-config-no-dup branch August 5, 2015 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants