SI-9273 Avoid unpositioned error for bare classOf#4449
Merged
retronym merged 1 commit intoscala:2.11.xfrom Apr 16, 2015
Merged
Conversation
A bare identifier `classOf` in a position wth an expected type of `Class[_]` was leading to an unpositioned error. This is due to special treatment of bare `classOf` in `typedIdent` creating an ephemeral, but unpositioned, `TypeTree`. This commit positions that tree and tests that the error is issued at a sensible position. There is still an irregularity between `classOf` and `Predef.classOf`, but that seems esoteric enough to leave alone for now.
Contributor
|
LGTM |
Contributor
|
@retronym I'm working on code which removes all special-casing for classOf in the compiler, that should remove the remaining issues. |
Member
Author
|
@soc Look forward to seeing that! |
retronym
added a commit
that referenced
this pull request
Apr 16, 2015
SI-9273 Avoid unpositioned error for bare classOf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare identifier
classOfin a position wth an expected type ofClass[_]was leading to an unpositioned error.This is due to special treatment of bare
classOfintypedIdentcreating an ephemeral, but unpositioned,
TypeTree.This commit positions that tree and tests that the error is
issued at a sensible position.
There is still an irregularity between
classOfandPredef.classOf,but that seems esoteric enough to leave alone for now.