change intArrayOps and friends return types for efficiency#4435
Merged
lrytz merged 2 commits intoscala:2.12.xfrom May 22, 2015
Merged
change intArrayOps and friends return types for efficiency#4435lrytz merged 2 commits intoscala:2.12.xfrom
lrytz merged 2 commits intoscala:2.12.xfrom
Conversation
Contributor
Author
|
Aha! Now we got to the (external) partest failure :) |
Contributor
Author
|
@xuwei-k, sorry, I won't have time to get this in for 2.12.0-M1. I'm moving this to M2. |
Suppress (transitive) dependency on external scala-library (through scala-partest). This caused trouble when binary compatibility was not preserved for scala-library, as in scala#4297. We already were doing this for `partest.compilation.path.noncore`, but we seem to have missed `quick.partest-extras.build.path`.
Contributor
Author
|
Re-reworked to leave non-implicit binary compatibility stubs in place. |
Remove object allocation overhead by peeling off abstraction layer, revealing that the `ArrayOps` implicit conversions in `Predef` return value classes. d3f879a turned `ArrayOps.of<???>` into value classes, but the non-`AnyVal` result type of the corresponding `<???>arrayOps` implicit conversions (`ArrayOps[_]`) caused boxing anyway. The optimized versions are introduced under a new name, so that the old ones (without `implicit`) can be kept for binary compatibility, for now.
Contributor
Author
|
/synch |
Contributor
Author
|
Woohoo! 🎈 review by @lrytz |
Member
|
LGTM! |
lrytz
added a commit
that referenced
this pull request
May 22, 2015
change intArrayOps and friends return types for efficiency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of #4297