Skip to content

SI-8689 Make a Future test case determistic#4414

Merged
retronym merged 1 commit intoscala:2.11.xfrom
retronym:topic/flaky
Mar 31, 2015
Merged

SI-8689 Make a Future test case determistic#4414
retronym merged 1 commit intoscala:2.11.xfrom
retronym:topic/flaky

Conversation

@retronym
Copy link
Member

@retronym retronym commented Mar 30, 2015

As discussed:

https://groups.google.com/forum/#!topic/scala-internals/m8I_3GQR4vQ

We need to ensure a happens-before relationship between the callback
that prints "success" and the end of the main method.

Review by @lrytz

Should be backported to 2.10.x

@scala-jenkins scala-jenkins added this to the 2.11.7 milestone Mar 30, 2015
@retronym retronym mentioned this pull request Mar 30, 2015
Merged
@retronym
SI-8689 Make a Future test case determistic
b31098c 
As discussed:

  https://groups.google.com/forum/#!topic/scala-internals/m8I_3GQR4vQ

We need to ensure a happens-before relationship between the callback
that prints "success" and the end of the main method.
@retronym
Copy link
Member Author

retronym commented Mar 31, 2015 

quick.scalap:
    [mkdir] Created dir: /home/jenkins/workspace/scala-2.11.x-validate-publish-core/build/quick/classes/scalap
[quick.scalap] Compiling 23 files to /home/jenkins/workspace/scala-2.11.x-validate-publish-core/build/quick/classes/scalap
FATAL: Unable to delete script file /tmp/hudson428232164407244031.sh
hudson.remoting.RequestAbortedException: hudson.remoting.Channel$OrderlyShutdown
    at hudson.remoting.Request.abort(Request.java:296)
    at hudson.remoting.Channel.terminate(Channel.java:815)
    at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1033)
    at hudson.remoting.Channel$2.handle(Channel.java:484)
    at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:60)
    at ......remote call to jenkins-worker-behemoth-1(Native Method)
    at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1360)
    at hudson.remoting.Request.call(Request.java:171)
    at hudson.remoting.Channel.call(Channel.java:752)
    at hudson.FilePath.act(FilePath.java:978)
    at hudson.FilePath.act(FilePath.java:967)
    at hudson.FilePath.delete(FilePath.java:1421)
    at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:106)
    at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:66)
    at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
    at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:761)
    at hudson.model.Build$BuildExecution.build(Build.java:203)
    at hudson.model.Build$BuildExecution.doRun(Build.java:160)
    at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:536)
    at hudson.model.Run.execute(Run.java:1751)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:89)
    at hudson.model.Executor.run(Executor.java:240)
Caused by: hudson.remoting.Channel$OrderlyShutdown
    at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1033)
    at hudson.remoting.Channel$2.handle(Channel.java:484)
    at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:60)
Caused by: Command close created at
    at hudson.remoting.Command.<init>(Command.java:56)
    at hudson.remoting.Channel$CloseCommand.<init>(Channel.java:1027)
    at hudson.remoting.Channel$CloseCommand.<init>(Channel.java:1025)
    at hudson.remoting.Channel.close(Channel.java:1108)
    at hudson.remoting.Channel.close(Channel.java:1091)
    at hudson.remoting.Channel$CloseCommand.execute(Channel.java:1032)
    ... 2 more
Build was aborted

@retronym
Copy link
Member Author

retronym commented Mar 31, 2015

I encountered this failure in IDE validation on an earlier attempt:

Caused by: java.net.URISyntaxException: Illegal character in path at index 52: http://private-repo.typesafe.com/typesafe/ide-Select a Scala profile/org/scala-lang/scala-library/2.10.5-SNAPSHOT/scala-library-2.10.5-SNAPSHOT.pom
    at java.net.URI$Parser.fail(URI.java:2810)

It seems like we are missing the Maven option -Pscala-2.11.x.

@retronym
Copy link
Member Author

retronym commented Mar 31, 2015

/rebuild

@lrytz
Copy link
Member

lrytz commented Mar 31, 2015

LGTM

retronym added a commit that referenced this pull request Mar 31, 2015
@retronym
Merge pull request #4414 from retronym/topic/flaky
c8757cd 
SI-8689 Make a Future test case determistic
@retronym retronym merged commit c8757cd into scala:2.11.x Mar 31, 2015
@retronym retronym mentioned this pull request Mar 31, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.11.7

Development

Successfully merging this pull request may close these issues.

3 participants

@retronym @lrytz @scala-jenkins