SI-7775 Exclude nulls when iterating sys props#4372
Merged
lrytz merged 1 commit intoscala:2.12.xfrom Mar 23, 2015
Merged
Conversation
The previous fix to deal with concurrent modification of system properties doesn't handle null results introduced when a property is removed. This commit filters nulls for safety, and also adds a `names` method to `sys.SystemProperties`. The test is upgraded.
3667673 to
17caf79
Compare
Contributor
Author
Member
|
LGTM! |
lrytz
added a commit
that referenced
this pull request
Mar 23, 2015
SI-7775 Exclude nulls when iterating sys props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix to deal with concurrent modification of system
properties doesn't handle null results introduced when a property
is removed.
This commit filters nulls for safety, and also adds a
namesmethod to
sys.SystemProperties.The test is upgraded.
Motivated by the same bug at sbt
sbt/sbt#1893 (comment)
and this impending change that would make the test stop testing
#4285 (comment)
It's too late to help sbt.