Skip to content

SI-8642 Enable OSGi tests under Java 8#4271

Merged
adriaanm merged 2 commits intoscala:2.11.xfrom
retronym:ticket/8642
Jan 28, 2015
Merged

SI-8642 Enable OSGi tests under Java 8#4271
adriaanm merged 2 commits intoscala:2.11.xfrom
retronym:ticket/8642

Conversation

@retronym
Copy link
Member

Details in the commit messages.

@retronym
Copy link
Member Author

Review by @soc or @rkrzewski, please.

@scala-jenkins scala-jenkins added this to the 2.11.6 milestone Jan 28, 2015
@retronym
Copy link
Member Author

/rebuild

@adriaanm
Copy link
Contributor

the worker is out of disk space.. please excuse the dust while I attach an EBS volume

@adriaanm
Copy link
Contributor

/synch

@adriaanm
Copy link
Contributor

/rebuild

@adriaanm
Copy link
Contributor

You'll have to rebase on #4268 -- hopefully should work then.

We can now edit these in IntelliJ, as per the regular JUnit tests.
We use the PAX Exam framework to integration test that the
OSGi metadata we add to our JARs allows them to be loaded
into the Felix and Equinox containers. However, we had to
disable this test under Java 8 due to an incompatibility between
that framework and the modern Java version.

I have found a combination that works in Java 6, 7, and 8,
so the test is now run under all Java versions.

I have left a `skip` property to disable them, following the
established convention.

Tip of the hat to:

  - @soc / @rkrzewski for the work in scala#4066 that paved the way
    for this small change
  - Harald Wellman, for sharing [1] the Java 8 compatible combination
    of PAX and Felix .

Testing:

```
for V in 1.6 1.7 1.8; do java_use $V; ant -q test.osgi; done
java version "1.6.0_65"
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-466.1-11M4716)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-466.1, mixed mode)
     ...
     [echo] Running OSGi JUnit tests. Output in /Users/jason/code/scala3/build/osgi
     [echo] Test pass 1 of 2 using Apache Felix 4.4.0
     [echo] Test pass 2 of 2 using Eclipse Equinox 3.7.1

BUILD SUCCESSFUL
Total time: 31 seconds
java version "1.7.0_71"
Java(TM) SE Runtime Environment (build 1.7.0_71-b14)
Java HotSpot(TM) 64-Bit Server VM (build 24.71-b01, mixed mode)
     ...
     [echo] Running OSGi JUnit tests. Output in /Users/jason/code/scala3/build/osgi
     [echo] Test pass 1 of 2 using Apache Felix 4.4.0
     [echo] Test pass 2 of 2 using Eclipse Equinox 3.7.1

BUILD SUCCESSFUL
Total time: 22 seconds
java version "1.8.0_25"
Java(TM) SE Runtime Environment (build 1.8.0_25-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.25-b02, mixed mode)
     ...
     [echo] Running OSGi JUnit tests. Output in /Users/jason/code/scala3/build/osgi
     [echo] Test pass 1 of 2 using Apache Felix 4.4.0
     [echo] Test pass 2 of 2 using Eclipse Equinox 3.7.1

BUILD SUCCESSFUL
Total time: 16 seconds
```

[1] https://groups.google.com/d/msg/ops4j/TN0sZFf6wLs/vUP0GML6-TQJ
@retronym
Copy link
Member Author

/rebuild

@retronym
Copy link
Member Author

See: https://github.com/adriaanm/scala-jenkins-infra/pull/14 for an attempt to fix the build errors.

@adriaanm
Copy link
Contributor

/rebuild

@adriaanm
Copy link
Contributor

Yeah! 🎆

@adriaanm
Copy link
Contributor

LGTM!

@rkrzewski
Copy link
Contributor

LGTM

adriaanm added a commit that referenced this pull request Jan 28, 2015
SI-8642 Enable OSGi tests under Java 8
@adriaanm adriaanm merged commit 7b5998a into scala:2.11.x Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants