SI-8462: Int shift Long result corrected#4238
Merged
gkossakowski merged 1 commit intoscala:2.12.xfrom Jan 14, 2015
Merged
Conversation
Contributor
|
This ticket is related to all such problems with bitwise shifts - not only to integers. I mean there were problems also in the case of characters, e.g: On the other hand your changes already corrected also characters so, please, add also tests for them. Except this one remark it seems to look okay. |
Constant folding was incorrectly promoting to Long when the operand was Long, as with other binary ops, but the result type depends on the receiver. Per SLS 12.2.1. This fixes ((1 << 2L): Int) and the other shift ops and the other integral types.
Contributor
Author
|
Augmented the message and test. |
Contributor
|
LGTM |
Contributor
|
Thanks! |
gkossakowski
added a commit
that referenced
this pull request
Jan 14, 2015
SI-8462: Int shift Long result corrected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant folding was incorrectly promoting to Long when the
operand was Long, as with other binary ops, but the result
type depends on the receiver.
Per SLS 12.2.1.
This fixes ((1 << 2L): Int) and the other shift ops.