SI-8841 report named arg / assignment ambiguity also in silent mode.#4195
Merged
adriaanm merged 1 commit intoscala:2.11.xfrom Feb 13, 2015
Merged
SI-8841 report named arg / assignment ambiguity also in silent mode.#4195adriaanm merged 1 commit intoscala:2.11.xfrom
adriaanm merged 1 commit intoscala:2.11.xfrom
Conversation
Contributor
|
It must be Thursday. Nicely scrounged. |
For local definitions (eg. in a block that is an argument of a method call), the type completer may have a silent context. A CyclicReference is then not thrown but transformed into a NormalTypeError. When deciding if 'x = e' is an assignment or a named arg, we need to report cyclic references, but not other type errors. In the above case, the cyclic reference was not reported. Also makes sure that warnings are printed after typing argument expressions.
Member
Author
|
Review by @retronym - note the change in t8463.check and the existing comment in t8463.scala |
Contributor
|
ping @retronym |
Contributor
|
I'll merge the last 2.11.5 PRs my Monday morning, if they have been LGTM'ed by then. |
Contributor
|
At midnight on xmas eve, Santa brings lgtms to all the good girls and boys. His army of elf coders is hard at work until then. In fact, they were responsible for the Sony hack. A disagreement over Santa's discount on PS4s. |
Contributor
|
Is that why he went with the mach-o coders this year? I hear they're indifferent to discounts. |
Contributor
|
In principle, this LGTM, but I'd rather not merge typer changes right before the elves take over. Moved to 2.11.6. |
Member
|
LGTM |
adriaanm
added a commit
that referenced
this pull request
Feb 13, 2015
SI-8841 report named arg / assignment ambiguity also in silent mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For local definitions (eg. in a block that is an argument of a method
call), the type completer may have a silent context. A CyclicReference
is then not thrown but transformed into a NormalTypeError. When
deciding if 'x = e' is an assignment or a named arg, we need to report
cyclic references, but not other type errors. In the above case, the
cyclic reference was not reported.
Also makes sure that warnings are printed after typing argument
expressions.