SI-8519 collection.immutable.Map.apply is inefficient#4155
SI-8519 collection.immutable.Map.apply is inefficient#4155retronym merged 1 commit intoscala:2.12.xfrom
Conversation
|
Note: JIRA didn't let me log in, so I haven't linked to this PR from there. |
|
The test passes on my machine...not sure what the issue is? |
|
PLS REBUILD/pr-scala@693b0647f86e9702ac21e87f5e093346bf2d6edd |
|
(kitty-note-to-self: ignore 64290201) |
Your change might have changed the implied We might be able to retrofit I think the principled approach is to actually use the serialization proxy pattern to avoid serializing these To help debugging, here's how to extract the SerialVersionUID (calculated or explicitly annotated) of a class programatically: |
|
@retronym - Thanks, I should have looked into it more deeply to see why it was failing. (Not the first time I have forgotten the difference between -optimize and not.) I guess we're trying to be serialization compatible in 2.12, so the thing to do for now would be to apply the annotation. |
Added customized apply and contains methods for EmptyMap, Map1 - Map4 and ListMap (both EmptyListMap and Node). The modifications appear to be able to (sometimes) change the SerialVersionUID of EmptyListMap, so that has been fixed at the old value.
You can also use the |
There was a problem hiding this comment.
could eliminate the excess newline
|
LGTM, otherwise |
|
LGTM, too. |
SI-8519 collection.immutable.Map.apply is inefficient
Added customized apply and contains methods for EmptyMap - Map4 and ListMap (both empty and Node).