SI-7602 Avoid crash in LUBs with erroneous code#4097
Merged
retronym merged 1 commit intoscala:2.11.xfrom Nov 7, 2014
Merged
Conversation
Member
Author
|
Review by @adriaanm |
Contributor
|
Could you add a note to future refactorer/optimizer explaining why not |
Member
Author
|
done |
Contributor
|
LGTM! |
Contributor
|
actually, sorry, could you |
Member
Author
|
Sure, done. |
Contributor
|
PLS REBUILD ALL |
|
(kitty-note-to-self: ignore 61963883) |
Member
Author
|
PLS REBUILD ALL I've taken three Jenkins nodes offline that seem to be failing ( |
|
(kitty-note-to-self: ignore 61974296) |
Member
Author
|
Forgot a check file, that is the only change in the latest commit. |
If a class contains a double defintion of a method that overrides an interface method, LUBs could run into a spot where filtering overloaded alternatives to those that match the interface method fails to resolve to a single overload, which crashes the compiler. This commit uses `filter` rather than `suchThat` to avoid the crash.
retronym
added a commit
that referenced
this pull request
Nov 7, 2014
SI-7602 Avoid crash in LUBs with erroneous code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a class contains a double defintion of a method that overrides
an interface method, LUBs could run into a spot where filtering
overloaded alternatives to those that match the interface method
fails to resolve to a single overload, which crashes the compiler.
This commit uses
filterrather thansuchThatto avoid the crash.