SI-7019 Fix crasher with private[this] extension methods#4096
Merged
retronym merged 1 commit intoscala:2.11.xfrom Nov 7, 2014
Merged
SI-7019 Fix crasher with private[this] extension methods#4096retronym merged 1 commit intoscala:2.11.xfrom
retronym merged 1 commit intoscala:2.11.xfrom
Conversation
Member
|
|
When we move the body of value class methods to the corresponding extension method, we typecheck a forward method that remains in the class. In order to allow access, this commit weakens the access of `private[local]` extension methods to `private`.
Member
Author
|
Permuted back into shape! |
Member
|
LGTM! |
retronym
added a commit
that referenced
this pull request
Nov 7, 2014
SI-7019 Fix crasher with private[this] extension methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we move the body of value class methods to the corresponding
extension method, we typecheck a forward method that remains
in the class. In order to allow access, this commit weakens the
access of
private[local]extension methods toprivate.Review by @lrytz