SI-8960 Bring back the SerialVersionUID to anonymous function classes#4093
Merged
lrytz merged 1 commit intoscala:2.11.xfrom Nov 6, 2014
Merged
SI-8960 Bring back the SerialVersionUID to anonymous function classes#4093lrytz merged 1 commit intoscala:2.11.xfrom
lrytz merged 1 commit intoscala:2.11.xfrom
Conversation
Member
Author
|
Review by @retronym |
Member
|
The ghost of 4267444 comes back to haunt us again. |
Member
|
Let's expand the test with:
|
In PR scala#1673 / 4267444, the annotation `SerialVersionId` was changed from a `StaticAnnotation` to `ClassFileAnnotation` in order to enforce annotation arguments to be constants. That was 2.11.0. The ID value in the AnnotationInfo moved from `args` to `assocs`, but the backend was not adjusted. This was fixed in PR scala#3711 / ecbc9d0 for 2.11.1. Unfortunately, the synthetic AnnotationInfo that is added to anonymous function classes still used the old constructor (`args` instead of `assocs`), so extracting the value failed, and no field was added to the classfile.
Member
Author
|
Updated the tests. |
Member
|
LGTM. Could you proactively add a note about this to the release notes for 2.11.5? |
Member
Author
lrytz
added a commit
that referenced
this pull request
Nov 6, 2014
SI-8960 Bring back the SerialVersionUID to anonymous function classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #1673 / 4267444, the annotation
SerialVersionIdwas changedfrom a
StaticAnnotationtoClassFileAnnotationin order to enforceannotation arguments to be constants. That was 2.11.0.
The ID value in the AnnotationInfo moved from
argstoassocs, butthe backend was not adjusted. This was fixed in PR #3711 / ecbc9d0 for
2.11.1.
Unfortunately, the synthetic AnnotationInfo that is added to anonymous
function classes still used the old constructor (
argsinstead ofassocs), so extracting the value failed, and no field was added tothe classfile.