SI-5091 Move named-args cycle test from pending to neg#4044
Merged
lrytz merged 3 commits intoscala:2.11.xfrom Nov 5, 2014
Merged
SI-5091 Move named-args cycle test from pending to neg#4044lrytz merged 3 commits intoscala:2.11.xfrom
lrytz merged 3 commits intoscala:2.11.xfrom
Conversation
There is a typechecking cycle, and since 4669ac1 we now report this in a clearer manner. Once we change the language to unconditionally interpret an assignent in argument position as a named argument would be the only way to get this over to `pos`.
Member
Author
|
ping @lrytz |
Member
|
LGTM, i added a test case for SI-6051 (which seems to be fixed) in retronym#7. |
SI-6051 Test case, the issue seems to be fixed.
Member
|
PLS REBUILD/pr-scala@ba9b4cca0408bbba51e56dbd96ca7e87a115e0e4 |
|
(kitty-note-to-self: ignore 61639980) |
lrytz
added a commit
that referenced
this pull request
Nov 5, 2014
SI-5091 Move named-args cycle test from pending to neg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a typechecking cycle, and since 4669ac1 we now report
this in a clearer manner.
Once we change the language to unconditionally interpret an
assignent in argument position as a named argument would be the
only way to get this over to
pos.Review by @lrytz