SI-6502 Repl reset/replay take settings args by som-snytt · Pull Request #3986 · scala/scala

som-snytt · 2014-09-16T06:57:35Z

The reset and replay commands take arbitrary command line args.
When settings args are supplied, the compiler is recreated.

For uniformity, the settings command performs only the usual
arg parsing: use -flag:true or -flag instead of +flag, and clearing a
setting is promoted to the command line, so that -Xlint: is not
an error but clears the flags.

scala> maqicode.Test main null
<console>:8: error: not found: value maqicode
              maqicode.Test main null
              ^

scala> :reset -classpath/a target/scala-2.11/sample_2.11-1.0.jar
Resetting interpreter state.
Forgetting all expression results and named terms: $intp

scala> maqicode.Test main null
Hello, world.

scala> val i = 42
i: Int = 42

scala> s"$i is the loneliest numbah."
res1: String = 42 is the loneliest numbah.

scala> :replay -classpath ""
Replaying: maqicode.Test main null
Hello, world.

Replaying: val i = 42
i: Int = 42

Replaying: s"$i is the loneliest numbah."
res1: String = 42 is the loneliest numbah.

scala> :replay -classpath/a ""
Replaying: maqicode.Test main null
<console>:8: error: not found: value maqicode
              maqicode.Test main null
              ^

Replaying: val i = 42
i: Int = 42

Replaying: s"$i is the loneliest numbah."
res1: String = 42 is the loneliest numbah.

Clearing a clearable setting:

scala> :reset -Xlint:missing-interpolator
Resetting interpreter state.

scala> { val i = 42 ; "$i is the loneliest numbah." }
<console>:8: warning: possible missing interpolator: detected interpolated identifier `$i`
              { val i = 42 ; "$i is the loneliest numbah." }
                             ^
res0: String = $i is the loneliest numbah.

scala> :reset -Xlint:
Resetting interpreter state.
Forgetting this session history:

{ val i = 42 ; "$i is the loneliest numbah." }

scala> { val i = 42 ; "$i is the loneliest numbah." }
res0: String = $i is the loneliest numbah.

scala> :replay -Xlint:missing-interpolator
Replaying: { val i = 42 ; "$i is the loneliest numbah." }
<console>:8: warning: possible missing interpolator: detected interpolated identifier `$i`
              { val i = 42 ; "$i is the loneliest numbah." }
                             ^
res0: String = $i is the loneliest numbah.

Review by @gkossakowski

som-snytt · 2014-09-16T14:53:14Z

PLS REBUILD/pr-scala@13e9317

scala-jenkins · 2014-09-16T14:53:35Z

(kitty-note-to-self: ignore 55755093)
🐱 Roger! Rebuilding pr-scala for 13e9317. 🚨

som-snytt · 2014-09-22T06:38:54Z

src/repl/scala/tools/nsc/interpreter/ILoop.scala

doesn't reflect arbitrary settings.

People expect to change the class path midstream. Let's disabuse them by removing the broken command. The internals are deprecated.

The reset and replay commands take arbitrary command line args. When settings args are supplied, the compiler is recreated. For uniformity, the settings command performs only the usual arg parsing: use -flag:true instead of +flag, and clearing a setting is promoted to the command line, so that -Xlint: is not an error but clears the flags. ``` scala> maqicode.Test main null <console>:8: error: not found: value maqicode maqicode.Test main null ^ scala> :reset -classpath/a target/scala-2.11/sample_2.11-1.0.jar Resetting interpreter state. Forgetting all expression results and named terms: $intp scala> maqicode.Test main null Hello, world. scala> val i = 42 i: Int = 42 scala> s"$i is the loneliest numbah." res1: String = 42 is the loneliest numbah. scala> :replay -classpath "" Replaying: maqicode.Test main null Hello, world. Replaying: val i = 42 i: Int = 42 Replaying: s"$i is the loneliest numbah." res1: String = 42 is the loneliest numbah. scala> :replay -classpath/a "" Replaying: maqicode.Test main null <console>:8: error: not found: value maqicode maqicode.Test main null ^ Replaying: val i = 42 i: Int = 42 Replaying: s"$i is the loneliest numbah." res1: String = 42 is the loneliest numbah. ``` Clearing a clearable setting: ``` scala> :reset -Xlint:missing-interpolator Resetting interpreter state. scala> { val i = 42 ; "$i is the loneliest numbah." } <console>:8: warning: possible missing interpolator: detected interpolated identifier `$i` { val i = 42 ; "$i is the loneliest numbah." } ^ res0: String = $i is the loneliest numbah. scala> :reset -Xlint: Resetting interpreter state. Forgetting this session history: { val i = 42 ; "$i is the loneliest numbah." } scala> { val i = 42 ; "$i is the loneliest numbah." } res0: String = $i is the loneliest numbah. ```

som-snytt · 2014-09-22T07:02:25Z

Rebased and corrected :help.

som-snytt · 2014-09-26T15:19:57Z

PLS REBUILD/pr-scala@e720bab

scala-jenkins · 2014-09-26T15:24:10Z

(kitty-note-to-self: ignore 56975950)
🐱 Roger! Rebuilding pr-scala for e720bab. 🚨

adriaanm · 2014-10-07T09:36:23Z

ping @gkossakowski

gkossakowski · 2014-10-07T11:13:44Z

LGTM

gkossakowski · 2014-10-07T11:15:47Z

Excellent work!

SI-6502 Repl reset/replay take settings args

@som-snytt

….10) Fixes SI-6502, reenables loading jars into the running REPL (regression in 2.10). This PR allows adding a jar to the compile and runtime classpaths without resetting the REPL state (crucial for Spark SPARK-3257). This follows the lead taken by @som-snytt in PR scala#3986, which differentiates two jar-loading behaviors (muddled by cp): - adding jars and replaying REPL expressions (using replay) - adding jars without resetting the REPL (deprecated cp, introduced require) This PR implements require (left unimplemented in scala#3986) This PR is a simplification of a similar approach taken by @gkossakowski in scala#3884. In this attempt, we check first to make sure that a jar is only added if it only contains new classes/traits/objects, otherwise we emit an error. This differs from the old invalidation approach which also tracked deleted classpath entries.

@som-snytt

….10) Fixes SI-6502, reenables loading jars into the running REPL (regression in 2.10). This PR allows adding a jar to the compile and runtime classpaths without resetting the REPL state (crucial for Spark SPARK-3257). This follows the lead taken by @som-snytt in PR scala#3986, which differentiates two jar-loading behaviors (muddled by cp): - adding jars and replaying REPL expressions (using replay) - adding jars without resetting the REPL (deprecated cp, introduced require) This PR implements require (left unimplemented in scala#3986) This PR is a simplification of a similar approach taken by @gkossakowski in scala#3884. In this attempt, we check first to make sure that a jar is only added if it only contains new classes/traits/objects, otherwise we emit an error. This differs from the old invalidation approach which also tracked deleted classpath entries.

@som-snytt

….10) Fixes SI-6502, reenables loading jars into the running REPL (regression in 2.10). This PR allows adding a jar to the compile and runtime classpaths without resetting the REPL state (crucial for Spark SPARK-3257). This follows the lead taken by @som-snytt in PR scala#3986, which differentiates two jar-loading behaviors (muddled by cp): - adding jars and replaying REPL expressions (using replay) - adding jars without resetting the REPL (deprecated cp, introduced require) This PR implements require (left unimplemented in scala#3986) This PR is a simplification of a similar approach taken by @gkossakowski in scala#3884. In this attempt, we check first to make sure that a jar is only added if it only contains new classes/traits/objects, otherwise we emit an error. This differs from the old invalidation approach which also tracked deleted classpath entries.

scala-jenkins added this to the 2.11.3 milestone Sep 16, 2014

scala-jenkins added the needs-attention label Sep 16, 2014

som-snytt force-pushed the issue/6502-no-cp branch from b352518 to 2e79986 Compare September 16, 2014 14:49

scala-jenkins added tested and removed needs-attention labels Sep 16, 2014

som-snytt reviewed Sep 22, 2014
View reviewed changes

src/repl/scala/tools/nsc/interpreter/ILoop.scala Outdated

Copy link

Contributor Author

som-snytt Sep 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't reflect arbitrary settings.

som-snytt added 2 commits September 21, 2014 23:40

SI-6502 Remove cp command as unworkable

2529010

People expect to change the class path midstream. Let's disabuse them by removing the broken command. The internals are deprecated.

som-snytt force-pushed the issue/6502-no-cp branch from 2e79986 to e720bab Compare September 22, 2014 07:00

scala-jenkins added needs-attention and removed tested labels Sep 22, 2014

scala-jenkins added tested and removed needs-attention labels Sep 26, 2014

gkossakowski self-assigned this Oct 7, 2014

scala-jenkins added the reviewed label Oct 7, 2014

gkossakowski added a commit that referenced this pull request Oct 7, 2014

Merge pull request #3986 from som-snytt/issue/6502-no-cp

47ab999

SI-6502 Repl reset/replay take settings args

gkossakowski merged commit 47ab999 into scala:2.11.x Oct 7, 2014

heathermiller mentioned this pull request Oct 14, 2014

SI-6502 Reenables loading jars into the running REPL (regression in 2.10) #4051

Merged

som-snytt deleted the issue/6502-no-cp branch February 9, 2015 01:19

scabug mentioned this pull request Apr 7, 2017

:cp does not work scala/bug#6502

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SI-6502 Repl reset/replay take settings args#3986

SI-6502 Repl reset/replay take settings args#3986
gkossakowski merged 2 commits intoscala:2.11.xfrom
som-snytt:issue/6502-no-cp

som-snytt commented Sep 16, 2014

Uh oh!

som-snytt commented Sep 16, 2014

Uh oh!

scala-jenkins commented Sep 16, 2014

Uh oh!

som-snytt Sep 22, 2014

Uh oh!

som-snytt commented Sep 22, 2014

Uh oh!

som-snytt commented Sep 26, 2014

Uh oh!

scala-jenkins commented Sep 26, 2014

Uh oh!

adriaanm commented Oct 7, 2014

Uh oh!

gkossakowski commented Oct 7, 2014

Uh oh!

gkossakowski commented Oct 7, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

som-snytt commented Sep 16, 2014

Uh oh!

som-snytt commented Sep 16, 2014

Uh oh!

scala-jenkins commented Sep 16, 2014

Uh oh!

som-snytt Sep 22, 2014

Choose a reason for hiding this comment

Uh oh!

som-snytt commented Sep 22, 2014

Uh oh!

som-snytt commented Sep 26, 2014

Uh oh!

scala-jenkins commented Sep 26, 2014

Uh oh!

adriaanm commented Oct 7, 2014

Uh oh!

gkossakowski commented Oct 7, 2014

Uh oh!

gkossakowski commented Oct 7, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants