Review by @Ichoran

Thanks for the review, and sorry for missing that. I assumed the bounds would be ok.
I've changed it to this:

override def toString = {
val start = Math.max(this.start, 0)
val end = Math.min(xs.length, start + length)

if (start >= end) "" else new String(xs, start, end - start)

}

And tested that with this:

val chars = "jdfhfjhdfkjasdfjkdsajkfasdjkfhasdkjfhsdafkj48r848rweruqewiuroqweoiruiwqeruoiwe".toCharArray

val ok = (1 to 10000000).forall { _ =>
val sign1 = if (Random.nextBoolean()) 1 else -1
val sign2 = if (Random.nextBoolean()) 1 else -1
val i1 = Random.nextInt(100) * sign1
val i2 = Random.nextInt(100) * sign2

val s1 = new FastArrayCharSequence(chars, i1, i2).toString()
val s2 = new ArrayCharSequence(chars, i1, i2).toString()
s1 == s2

}
println(ok)

I am a bit new to this, can i just commit the change to my branch (i did already) or do i need to rebase it into a single commit?

It is preferable to rebase into a single commit (git rebase -i HEAD~2 should do the trick).

ping @Ichoran

I tried rebasing it but i had to merge my remote branch again creating an extra empty commit. Not sure why... I hope it is ok like this.

@jeroentervoorde - You should be able to get a clean rebase by following these steps, assuming you've got "origin" as your remote github repository and "scala" as the main Scala one (let me know if this doesn't make sense to you; note that we normally name the branches issue/8589 not SI_8589):

(1) checkout your 2.11.x branch: git checkout 2.11.x
(2) pull the most recent Scala 2.11.x: git pull scala 2.11.x
(3) sync your github branch: git push origin 2.11.x
(4) switch to your new branch: git checkout SI_8589
(5) rebase to 2.11.x: git rebase 2.11.x
(6) merge all the existing patches:
(i) git rebase -i HEAD~4
(ii) change "pick" to "squash" for every patch of yours past the first
(7) push to github, forcing an overwrite of inconsistent history: git push -f origin SI_8589

I think it is ok now. Thanks very much for your help. I'm off reading the git book again :)

That part looks good. Any chance you can do it one more time to use math (i.e. scala.math) instead of Math (i.e. java.lang.Math), as I mentioned before?

Sorry, i missed that. It's updated now.

ping @Ichoran

@adriaanm - Whoops, overlooked this, sorry! LGTM

No worries -- please start your comment with LGTM when the LGTM is final -- that's what triggers the bot to add the "reviewed" label.

Thanks for the improvement, @jeroentervoorde!