Skip to content

Rebase #2727#2799

Closed
adriaanm wants to merge 7 commits intoscala:masterfrom
adriaanm:rebase-pr-2727
Closed

Rebase #2727#2799
adriaanm wants to merge 7 commits intoscala:masterfrom
adriaanm:rebase-pr-2727

Conversation

@adriaanm
Copy link
Copy Markdown
Contributor

@adriaanm adriaanm commented Aug 6, 2013

Rebased #2727. Should be good to go, @gkossakowski.

soc added 7 commits August 6, 2013 16:12
I left one warning untouched, because instead of adding the import the
diagnostics should be fixed:

    scala/src/library/scala/collection/parallel/mutable/LazyCombiner.scala:33:
    warning: the existential type
        scala.collection.parallel.mutable.LazyCombiner[_$1,_$2,_$3] forSome {
          type _$1; type _$2; type _$3 <: scala.collection.generic.Growable[_$1] with scala.collection.generic.Sizing },
    which cannot be expressed by wildcards, should be enabled by making the implicit value scala.language.existentials visible.
    if (other.isInstanceOf[LazyCombiner[_, _, _]]) {
                       ^
The files are not regenerated here, because additional fixes will
follow in the next commit.
This has grown to a much larger clean-up than originally intended ...
@gkossakowski
Copy link
Copy Markdown
Contributor

Thanks. I'll review once tests are run (which should be tomorrow).

@adriaanm
Copy link
Copy Markdown
Contributor Author

ping @gkossakowski

@ghost ghost assigned gkossakowski Aug 12, 2013
@gkossakowski
Copy link
Copy Markdown
Contributor

Thanks for pinging me. Last week was challenging when it comes to get any work done. I'll look into this today.

@gkossakowski
Copy link
Copy Markdown
Contributor

@soc: please address the review comments. I promise to be more responsive this week.

@soc
Copy link
Copy Markdown
Contributor

soc commented Aug 14, 2013

This one can be closed, but I lack the right to do it.

@adriaanm adriaanm deleted the rebase-pr-2727 branch December 10, 2013 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants