SI-7624 Fix -feature and some -Xlint warnings#2727
Closed
soc wants to merge 7 commits intoscala:masterfrom
soc:SI-7624
Closed
SI-7624 Fix -feature and some -Xlint warnings#2727soc wants to merge 7 commits intoscala:masterfrom soc:SI-7624
soc wants to merge 7 commits intoscala:masterfrom
soc:SI-7624
Conversation
Contributor
Author
Contributor
|
I'll have a look into this tomorrow. |
Contributor
|
PLS REBUILD ALL |
|
(kitty-note-to-self: ignore 21694070) |
Contributor
|
@soc: excellent work. Please address my two comments. |
I left one warning untouched, because instead of adding the import the
diagnostics should be fixed:
scala/src/library/scala/collection/parallel/mutable/LazyCombiner.scala:33:
warning: the existential type
scala.collection.parallel.mutable.LazyCombiner[_$1,_$2,_$3] forSome {
type _$1; type _$2; type _$3 <: scala.collection.generic.Growable[_$1] with scala.collection.generic.Sizing },
which cannot be expressed by wildcards, should be enabled by making the implicit value scala.language.existentials visible.
if (other.isInstanceOf[LazyCombiner[_, _, _]]) {
^
The files are not regenerated here, because additional fixes will follow in the next commit.
Contributor
Author
|
@gkossakowski @adriaanm I split the commit as mentioned (see 2nd and 3rd one). I also added a new one (6th) which fixes feature warnings is scala/tools/scalap, I must have missed that package the first time. |
This has grown to a much larger clean-up than originally intended ...
Contributor
Author
|
7th is new, too, but has no semantic changes. |
Contributor
|
@soc, accidentally deleted your comment, sorry! We'll take care of rebasing this PR since it took us so long to get it merged |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes build.xml to build Scala with
-featureenabled.