SI-7624 Fix -feature and some -Xlint warnings#2705
SI-7624 Fix -feature and some -Xlint warnings#2705soc wants to merge 4 commits intoscala:masterfrom soc:SI-7624
Conversation
I left one warning untouched, because instead of adding the import the
diagnostics should be fixed:
scala/src/library/scala/collection/parallel/mutable/LazyCombiner.scala:33:
warning: the existential type
scala.collection.parallel.mutable.LazyCombiner[_$1,_$2,_$3] forSome {
type _$1; type _$2; type _$3 <: scala.collection.generic.Growable[_$1] with scala.collection.generic.Sizing },
which cannot be expressed by wildcards, should be enabled by making the implicit value scala.language.existentials visible.
if (other.isInstanceOf[LazyCombiner[_, _, _]]) {
^
|
I have not modified BCode-related source files, because I don't want to cause any trouble when @magarciaEPFL pushes the next round of improvements. |
|
Review by @adriaanm/@phaller. |
|
IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/94/ |
|
IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/95/ |
|
IDE validation running at https://scala-webapps.epfl.ch/jenkins/job/pr-scala/96/ |
|
Nice! We should really get to a state where people can compile with -fatal-warnings (this may include a switch that suppresses inliner warnings). Also, one improvement to deprecation warnings would be not to warn when a deprecated member is called from a member that is similarly deprecated (as they will both disappear together) |
|
@adriaanm Deprecation is already suppressed as you describe. I don't know about "similarly". If two members are differentially deprecated, one will disappear first. In that case, -Xfuture -Xlint could emit the warning, "Don't you know that the method you're calling will be removed before you will?" |
|
Sorry, this can't be merged anymore, and I didn't want to merge it right before a release. |
Changes build.xml to build Scala with
-featureenabled.