Fix ArraySeq.ofFloat/ofDouble.equals for floating point#11083
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Jun 30, 2025
Merged
Fix ArraySeq.ofFloat/ofDouble.equals for floating point#11083lrytz merged 1 commit intoscala:2.13.xfrom
lrytz merged 1 commit intoscala:2.13.xfrom
Conversation
This fixes #13108 when comparing Seq[Float] with Seq[Float] it expected that Float.NaN != Float.NaN and 0.0 equals -0.0f. But before this patch this was violated by ArraySeq.ofFloat/ofDouble
Ichoran
approved these changes
Jun 28, 2025
Contributor
Ichoran
left a comment
There was a problem hiding this comment.
LGTM--looks like a straightforward and effective implementation of element-by-element equality!
hamzaremmal
pushed a commit
to scala/scala3
that referenced
this pull request
Sep 24, 2025
Fix ArraySeq.ofFloat/ofDouble.equals for floating point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes scala/bug#13108 when comparing Seq[Float] with Seq[Float] it expected
that Float.NaN != Float.NaN and 0.0 equals -0.0f. But before this patch
this was violated by ArraySeq.ofFloat/ofDouble