Skip to content

Fixes the annoying spaces between name, type params and params ...#11

Merged
paulp merged 1 commit intoscala:masterfrom
soc:scaladoc-spacing
Dec 2, 2011
Merged

Fixes the annoying spaces between name, type params and params ...#11
paulp merged 1 commit intoscala:masterfrom
soc:scaladoc-spacing

Conversation

@soc
Copy link
Contributor

@soc soc commented Dec 2, 2011

in ScalaDoc.

@paulp paulp merged commit 086b558 into scala:master Dec 2, 2011
cvogt pushed a commit to cvogt/scala that referenced this pull request Oct 8, 2012
Rearranged some reflection docs, moving things to the guide
snovgorodtsev-zz pushed a commit to SoftageRnD/scala that referenced this pull request Oct 13, 2013
retronym referenced this pull request in retronym/scala May 7, 2014
retronym added a commit that referenced this pull request Aug 6, 2015
Calls to synthetic case class apply methods are inlined to the
underlying constructor invocation in refchecks.

However, this can lead to accessibility errors if the constructor
is private.

This commit ensures that the constructor is at least as accessible
as the apply method before performing this tranform.

I've manually checked that other the optimization still works in other
cases:

scala> class CaseApply { Some(42)  }
defined class CaseApply

    scala> :javap -c CaseApply
    Compiled from "<console>"
    public class CaseApply {
      public CaseApply();
        Code:
           0: aload_0
           1: invokespecial #9                  // Method java/lang/Object."<init>":()V
           4: new           #11                 // class scala/Some
           7: dup
           8: bipush        42
          10: invokestatic  #17                 // Method scala/runtime/BoxesRunTime.boxToInteger:(I)Ljava/lang/Integer;
          13: invokespecial #20                 // Method scala/Some."<init>":(Ljava/lang/Object;)V
          16: pop
          17: return
    }
felixmulder pushed a commit to felixmulder/scala that referenced this pull request Apr 25, 2017
SD-233 synchronized blocks are JIT-friendly again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants