Fixes the annoying spaces between name, type params and params ...#11
Merged
paulp merged 1 commit intoscala:masterfrom Dec 2, 2011
soc:scaladoc-spacing
Merged
Fixes the annoying spaces between name, type params and params ...#11paulp merged 1 commit intoscala:masterfrom soc:scaladoc-spacing
paulp merged 1 commit intoscala:masterfrom
soc:scaladoc-spacing
Conversation
cvogt
pushed a commit
to cvogt/scala
that referenced
this pull request
Oct 8, 2012
Rearranged some reflection docs, moving things to the guide
snovgorodtsev-zz
pushed a commit
to SoftageRnD/scala
that referenced
this pull request
Oct 13, 2013
retronym
added a commit
that referenced
this pull request
Aug 6, 2015
Calls to synthetic case class apply methods are inlined to the
underlying constructor invocation in refchecks.
However, this can lead to accessibility errors if the constructor
is private.
This commit ensures that the constructor is at least as accessible
as the apply method before performing this tranform.
I've manually checked that other the optimization still works in other
cases:
scala> class CaseApply { Some(42) }
defined class CaseApply
scala> :javap -c CaseApply
Compiled from "<console>"
public class CaseApply {
public CaseApply();
Code:
0: aload_0
1: invokespecial #9 // Method java/lang/Object."<init>":()V
4: new #11 // class scala/Some
7: dup
8: bipush 42
10: invokestatic #17 // Method scala/runtime/BoxesRunTime.boxToInteger:(I)Ljava/lang/Integer;
13: invokespecial #20 // Method scala/Some."<init>":(Ljava/lang/Object;)V
16: pop
17: return
}
felixmulder
pushed a commit
to felixmulder/scala
that referenced
this pull request
Apr 25, 2017
SD-233 synchronized blocks are JIT-friendly again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in ScalaDoc.