Moved inline logic before pickler.#1095
Conversation
The test case failed due to separate compilation. The problem was that we don't pickle the fact that the field was made public. Original patch by @odersky. Cleaned up by me. Changes I made: * removed stale test-case * reduced whitespace changes Supersedes scala#1089. Review by @odersky and @moors.
|
Started jenkins job pr-rangepos at https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/137/ |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/840/ |
|
jenkins job pr-rangepos: Success - https://scala-webapps.epfl.ch/jenkins/job/pr-rangepos/137/ |
|
jenkins job pr-scala-testsuite-linux-opt: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/840/ |
|
Let's see if it's not a spurious failure. |
|
Started jenkins job pr-scala-testsuite-linux-opt at https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/846/ |
|
yeah i think this one tends to flake out from time to time |
|
jenkins job pr-scala-testsuite-linux-opt: Failed - https://scala-webapps.epfl.ch/jenkins/job/pr-scala-testsuite-linux-opt/846/ |
|
The last failure is spurious. All tests passed, and the build was successful. Also, I checked whether inlining warnings went away with this change. Almost none of them did. Investigating into it now. This is not a blocker to merge this change. |
Moved inline logic before pickler.
|
i fixed the build script, sorry 'bout that lrytz/jenkins-scripts@f101de7 |
|
PS: Merged with Martin's approval and verbal LGTM, as he wanted to try this change asap. |
The test case failed due to separate compilation. The problem was
that we don't pickle the fact that the field was made public.
Original patch by @odersky. Cleaned up by me. Changes I made:
Supersedes #1089.
Review by @odersky and @adriaanm.