Don't warn about synthetic apply if user-added#10562
Merged
lrytz merged 1 commit intoscala:2.13.xfrom Nov 8, 2023
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
lrytz
reviewed
Oct 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
a76a7d1 to
5e941aa
Compare
Contributor
Author
|
🎃 (squash) |
5e941aa to
3f79c85
Compare
Contributor
Author
|
🦃 (rebased) |
Member
|
The implementation looks good, thanks! I'm still unsure about issuing a warning that cannot be addressed with a code change. |
Contributor
Author
|
I will contribute distinguishing I see a commit, but I will have to organize a PR. It got mixed in with trying out I think you can approve this as addressing the immediate issue, and I will follow up for the separate issue about nuanced |
Member
|
Sounds good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve message for clarity.
Fix bug where warning for
applyis emitted too early, as the method may be "retracted" on completion if user-supplied.Split from #10551
Fixes scala/bug#12883