Build library under -Xsource:3 [ci: last-only]#10551
Closed
som-snytt wants to merge 1 commit intoscala:2.13.xfrom
Closed
Build library under -Xsource:3 [ci: last-only]#10551som-snytt wants to merge 1 commit intoscala:2.13.xfrom
som-snytt wants to merge 1 commit intoscala:2.13.xfrom
Conversation
05aa818 to
dc042c5
Compare
Contributor
Author
|
I did not intend to ignore |
Member
We might have to review if |
Contributor
|
🤔 --- a/src/library/scala/concurrent/duration/Deadline.scala
+++ b/src/library/scala/concurrent/duration/Deadline.scala
@@ -65,6 +65,8 @@ case class Deadline private (time: FiniteDuration) extends Ordered[Deadline] {
* The natural ordering for deadline is determined by the natural order of the underlying (finite) duration.
*/
def compare(other: Deadline): Int = time compare other.time
+
+ def copy(time: FiniteDuration = this.time): Deadline = Deadline(time)
}
object Deadline {
@@ -82,4 +84,5 @@ object Deadline {
def compare(a: Deadline, b: Deadline): Int = a compare b
}
+ def apply(time: FiniteDuration): Deadline = new Deadline(time) |
Contributor
|
FYI typelevel/cats use |
Contributor
Author
|
@xuwei-k thanks, it is also a dry-run to test the pain caused by |
Contributor
Author
|
I was going to try out "improved ergonomics for -Xsource", but I think I will not do that here, as I want the Scala 3 semantics, so that there is never a question if an inferred type shows up differently for Scala 3. |
Contributor
Author
|
Sample improved message The private constructor is an ancient restriction; one may question that choice, but probably we must respect it for now. The build needs to silence the old warnings for bootstrapping. |
28110b0 to
a9ba237
Compare
Contributor
Author
|
Drafting until improved |
Contributor
Author
|
Ready to fork the project so I can merge #10573 and profit. Closing until that is merged here. |
f6c0c59 to
898bb8f
Compare
898bb8f to
844918a
Compare
Contributor
Author
Locally, on restarr publish oh, maybe that never worked, publishLocal overwrites the local starr version. |
Contributor
Author
|
sigs via scalap, from overridden toString you get java.lang.String |
844918a to
230304c
Compare
Contributor
Author
|
squashed rebase of local branch, which seems to have some debug settings. Maybe I was tracking down those optimizer warnings? |
Contributor
Author
|
Weirdly, but it incurs a warning anyway. I haven't looked at it yet; this was the first opt warning. Or, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
-Xsource:3-cross, with the exclusion-Xsource-features:-case-companion-functionin the library.Stay on
-Xsource:2.13forscalap.The hardest part was the overrides in Scaladoc's
ModelFactory.What worked like a charm is:
Previously:
I did a quick jardiff.