Skip to content

Re-STARR onto 2.13.11-M1 and add JDK 20 (early access) to daily CI matrix#10335

Merged
SethTisue merged 3 commits intoscala:2.13.xfrom
SethTisue:restarr-jdk20
Mar 9, 2023
Merged

Re-STARR onto 2.13.11-M1 and add JDK 20 (early access) to daily CI matrix#10335
SethTisue merged 3 commits intoscala:2.13.xfrom
SethTisue:restarr-jdk20

Conversation

@SethTisue
Copy link
Copy Markdown
Member

@SethTisue SethTisue commented Mar 6, 2023

No description provided.

@scala-jenkins scala-jenkins added this to the 2.13.11 milestone Mar 6, 2023
@SethTisue SethTisue changed the title [nomerge] Re-STARR onto 2.13.11-M1 and add JDK 20 (early access) to daily CI matrix Re-STARR onto 2.13.11-M1 and add JDK 20 (early access) to daily CI matrix Mar 6, 2023
@SethTisue SethTisue self-assigned this Mar 6, 2023
@SethTisue SethTisue added internal not resulting in user-visible changes (build changes, tests, internal cleanups) prio:blocker release blocker (used only by core team, only near release time) labels Mar 6, 2023
@som-snytt
Copy link
Copy Markdown
Contributor

So many ex's.

!!  2 - run/doc-source-url.scala                  [output differs]
% diff /home/runner/work/scala/scala/test/scaladoc/run/doc-source-url.check /home/runner/work/scala/scala/test/scaladoc/run/doc-source-url-run.log
@@ -1 +1,41 @@
-Done.
+java.net.URISyntaxException: Illegal character in opaque part at index 43: file:test/scaladoc/resources/doc-source-url||.scala||test/scaladoc/resources/doc-source-url.scala||13

Might have to change the option to -doc-source-uri.

As a prefix of urinary, it recalls the childhood joke about Klingons circling Uranus. URL must mean urinal?

@SethTisue
Copy link
Copy Markdown
Member Author

SethTisue commented Mar 7, 2023

@som-snytt I used to work for an Uri, short for Uriel

just 3 failures now!

!!    1 - run/reflection-magicsymbols-invoke.scala  [output differs]
!!    2 - run/t6989                                 [output differs]
!!    3 - run/t9529                                 [output differs]

@som-snytt
Copy link
Copy Markdown
Contributor

My brain goes DarRen STARR every time. Actually writing it out, it looks creepy, like Darth Vader and Death Star, or the AI build bot that became self-aware and went on a rampage through the computer lab, scrawling DarRen STARR on the walls in white board marker.

@som-snytt
Copy link
Copy Markdown
Contributor

Right, these are the tests that fail locally for me. I was going to say that test names all start to look the same.

I wish I'd figured out the allocation tests before they started working again.

@SethTisue SethTisue marked this pull request as ready for review March 9, 2023 00:27
@SethTisue SethTisue requested a review from NthPortal as a code owner March 9, 2023 00:27
@SethTisue
Copy link
Copy Markdown
Member Author

I've removed the "DON'T MERGE ME -- temporarily enable GHA on this PR only" commit now that I've seen green runs.

@SethTisue SethTisue merged commit 35e3eff into scala:2.13.x Mar 9, 2023
@SethTisue SethTisue deleted the restarr-jdk20 branch March 9, 2023 18:47
@SethTisue SethTisue removed the prio:blocker release blocker (used only by core team, only near release time) label Mar 9, 2023
sjrd added a commit to scala/scala3 that referenced this pull request May 5, 2023
hamzaremmal pushed a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
hamzaremmal pushed a commit to scala/scala3 that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal not resulting in user-visible changes (build changes, tests, internal cleanups)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants