Fix 2.13.9 regression which broke binary compatibility of case classes which are also value classes#10155
Merged
lrytz merged 1 commit intoSep 26, 2022
Conversation
Member
|
Instead of full revert can we only add it to |
Contributor
Author
|
@joroKr21 That's an idea, if one were suitably motivated. However, the goal of the previous PR was to simplify. On the upside, "Fixed in Scala 3." Invoking the trait method is marginally better than the method on module The value class gets to call the extension method on its companion, where it is boxed and sent to |
This was referenced Sep 23, 2022
lrytz
approved these changes
Sep 26, 2022
lrytz
left a comment
Member
There was a problem hiding this comment.
Value classes agian... I agree to revert the change, at least as a first step. Thank you @som-snytt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12650, reverts #10002