Use normal mixed-in Product.productIterator#10002
Conversation
Omit generating the method and acquire the usual trait implementation. This follows Scala 3. (The special runtime support was added as an experiment and never removed when the experiment ended.)
384719f to
3cc2561
Compare
|
Was going to skip deprecating the utility method in |
|
I remember wondering why this method is generated. I guess it's one of those things that everyone assumed there is a good reason when there is none. 👍 maybe delete instead of commenting out? |
|
Yes, I meant to comment that I followed local code style in commenting out. I mentioned on Scala 3 that Scala 3 does |
joroKr21
left a comment
There was a problem hiding this comment.
Either way I'm in favour of this change
|
I will now follow up by deleting just the rogue iterator that is commented out here. In part to placate @joroKr21 |
|
I was about to add the deprecation of the runtime method, which we can't delete because of compatibility. But unbootstrapped build would complain. Yet perhaps I will suppress it. |
|
I think there should be a chat channel just for |
lrytz
left a comment
There was a problem hiding this comment.
👍 LGTM. Thanks to the mixin forwarder, case classes still have a productIterator method in bytecode, so there's no change for the runtime-generated SerialVersionUIDs.
|
MiMA user confused by the effect of this: lightbend-labs/mima#723 |
Omit generating the method and acquire the usual
trait implementation. This follows Scala 3.
(The special runtime support was added as an experiment
and never removed when the experiment ended.)