Move REPL related xsbti Java classes to the correct module#425
Merged
Move REPL related xsbti Java classes to the correct module#425
Conversation
xsbti Java classes were ported into compiler bridge, instead of the compiler interface by mistake. Since there's not code utilizing this interface yet, this was never caught.
dwijnand
previously approved these changes
Oct 9, 2017
Member
dwijnand
left a comment
There was a problem hiding this comment.
Is this change required by anything, or is it just cleaning up? Just curious. LGTM.
Member
Author
|
Over the weekend I was actually trying to implement something using this feature, and realized that it's broken. |
jvican
reviewed
Oct 9, 2017
build.sbt
Outdated
| publishLocal := publishLocal.dependsOn(cleanSbtBridge).value, | ||
| altPublishSettings, | ||
| mimaSettings, | ||
| mimaBinaryIssueFilters ++= Vector( |
Member
There was a problem hiding this comment.
I think we should follow the scalac standard of having this in an independent file. I don't like having this on the build.sbt.
Member
There was a problem hiding this comment.
I can think of two reasons:
- Every time I change something, It makes me reload the build.
- A file inside a project's source directories is clearer to find and read.
dwijnand
approved these changes
Oct 9, 2017
eed3si9n
commented
Oct 10, 2017
| ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleFactory") | ||
| ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleResult") | ||
| ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleInterface") | ||
| ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleResponse") |
Member
Author
There was a problem hiding this comment.
Mima exclusions moved to its own file, so is this ready to merge?
jvican
approved these changes
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xsbtiJava classes were ported into compiler bridge, instead of the compiler interface by mistake.Since there's not code utilizing this interface yet, this was never caught.
Ref #295