Conversation
eed3si9n
approved these changes
May 3, 2017
Member
eed3si9n
left a comment
There was a problem hiding this comment.
This brings back the old console API to unblock sbt.
LGTM
jvican
reviewed
May 3, 2017
| log, | ||
| Maybe.nothing[CompileProgress] | ||
| ) | ||
| val progress = Maybe.nothing[CompileProgress] |
Member
|
Weird, CI is not running at all. |
Member
|
Unfortunately, merging the formatting PR made this PR have conflicts. Can you update @dwijnand and I merge? |
Member
Author
|
Yeah, I knew merging your PR would have this effect. But I did it because it was 9 days in the making and this one is brand new, so I'll rebase my work. |
This fixes sbt console.
git checkout 0328ba4^ \
internal/compiler-bridge/src/main/scala/xsbt/ConsoleInterface.scala
cunei
pushed a commit
to cunei/zinc
that referenced
this pull request
Oct 25, 2017
Previously it was possible for the "current system time" to leak through into generated Calendar instance (and by extention Date instances). This was especially painful for generated functions (such as A => Date) where the function is likely to be evaluated at multiple different system times. This PR restructures Gen.calendar to ensure that all instances are initialized from a generated time (in milliseconds). The code is cleaned up a bit and a test was added to ensure generation is deterministic. Fixes sbt#295.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sbt/sbt#3129