Include private members in API hash of traits. (sbt/sbt#2160)#4
Merged
Include private members in API hash of traits. (sbt/sbt#2160)#4
Conversation
During compilation, scalac generates getters and setters for the fields of traits, regardless of their access modifiers. Therefore, when a field of a trait is modified, all its implementors must be recompiled to take these changes into account. Private fields of traits were not included in the API hash of traits, and their implementors were thus not recompiled when modified. This commit changes the way the API hash is computed for traits only, so that the generated hash includes the private members of traits. Fixes sbt/sbt#2155
Member
|
LGTM. This repos hould have travisCI running, but does not. Please do not merge until TravisCI report success. |
Contributor
Author
|
Triggering Travis |
Member
|
Given that Travis is now enabled: https://travis-ci.org/sbt/incrementalcompiler/builds/78530783, this should be ok to merge. |
eed3si9n
added a commit
that referenced
this pull request
Sep 8, 2015
Include private members in API hash of traits. (sbt/sbt#2160)
dwijnand
pushed a commit
to dwijnand/zinc
that referenced
this pull request
Jun 26, 2017
Clean the build and the warnings
dwijnand
pushed a commit
to dwijnand/zinc
that referenced
this pull request
Jun 26, 2017
Removes a warning. Ref sbt#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of sbt/sbt#2160.
I've included both commits, particularly the second that simply added back overloads to restore the binary compatibility. It's not required here, should I remove it?