Fix ConsoleInterface binding things properly^2#386
Conversation
|
Why is this targetting 1.0.1? |
|
Because @eed3si9n targeted the issue to 1.0.1: sbt/sbt#2884 (comment) |
|
If it's not going to be part of |
|
I thought about that, but I'd rather not get into the business of more persistent branches. I think we should merge it into the 1.0.0 branch and here are my reasons:
|
|
Oh and at this point in time the only thing in the 1.x branch that's not in the 1.0.0 branch is this inconsequential test classpath change: #328. |
|
Let's then aim for 1.0.0. I'm fine merging it and releasing RC4. |
So you are saying that RC-3 is still on its way to become 1.0.0 final, but you still want to merge this into If we plan to release 1.0.1 with bug fixes only, then we should create
Releasing RC-4 means delaying the entire sbt 1.0 and Zinc 1.0 for another week or two. |
Hmmm... if releasing a trivial fix is going to delay sbt 1.0, then we have a real problem with our tooling. Personally, I don't like making wrong decisions because of constraints on the tools I use -- if the current repo setup is causing too much pain, we should have a monorepo or something that emulates it. |
It's a matter of policy, not tooling. Even if we had a monorepo e.g. sbt/sbt, I would still push the final date by a week or two if we made any change to the code before calling it 1.0.0. |
bbe8de8 to
8df9a02
Compare
Follow-up on sbt#314 - I _still_ misinterpreted.. Turns out the ".asInstanceOf[AnyRef].getClass.getName" implementation was the _original_ implementation. Then Mark switched to using bindValue in sbt/sbt@4b8f0f3. Since Scala 2.11.0 (scala/scala#1648 in particular) bindValue was removed. So we'll use NamedParam and quietBind, both which exist since Scala 2.9.0. Fixes sbt/sbt#2884, tested with local releases.
8df9a02 to
33d2e68
Compare
Follow-up on #314 - I still misinterpreted..
Turns out the ".asInstanceOf[AnyRef].getClass.getName" implementation
was the original implementation. Then Mark switched to using bindValue
in sbt/sbt@4b8f0f3.
Since Scala 2.11.0 (scala/scala#1648 in particular) bindValue was
removed. So we'll use NamedParam and quietBind, both which exist since
Scala 2.9.0.
Fixes sbt/sbt#2884, tested with local releases.