Skip to content

Drop util-testing in favour of existing UnitSpec#328

Merged
dwijnand merged 1 commit intosbt:1.xfrom
dwijnand:drop-util-testing
Jul 26, 2017
Merged

Drop util-testing in favour of existing UnitSpec#328
dwijnand merged 1 commit intosbt:1.xfrom
dwijnand:drop-util-testing

Conversation

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Jun 30, 2017

No description provided.

@dwijnand
Copy link
Member Author

dwijnand commented Jul 2, 2017

No idea what's happened to Drone. Let's give it the old close-and-reopen treatment.

@dwijnand dwijnand closed this Jul 2, 2017
@dwijnand dwijnand reopened this Jul 2, 2017
@dwijnand
Copy link
Member Author

dwijnand commented Jul 3, 2017

Looks like Drone won't trigger on this.. Great.

@dwijnand dwijnand force-pushed the drop-util-testing branch from 4fb229a to cfc6369 Compare July 6, 2017 14:05
@sbt sbt deleted a comment from typesafe-tools Jul 6, 2017
@dwijnand
Copy link
Member Author

dwijnand commented Jul 6, 2017

Note to self: failing because the addition of zincTesting to zincClassfile doesn't work because:

  • zincTesting depends on lm
  • zincClassfile cross-builds to Scala 2.10
  • there is lm doesn't cross-build to Scala 2.10

@dwijnand dwijnand changed the base branch from 1.0 to 1.x July 17, 2017 15:13
@dwijnand dwijnand force-pushed the drop-util-testing branch from cfc6369 to 35f904a Compare July 18, 2017 10:23
@dwijnand
Copy link
Member Author

dwijnand commented Jul 18, 2017

Ignoring AppVeyor, this is actually green.

@dwijnand dwijnand requested review from Duhemm, eed3si9n and jvican July 19, 2017 07:36
jvican
jvican approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging!

@jvican
Copy link
Member

jvican commented Jul 19, 2017

Oops, no, @Duhemm has to review this one yet.

@dwijnand
Copy link
Member Author

dwijnand commented Jul 26, 2017

@eed3si9n or @Duhemm, thoughts? I'm trying to diminish the dependencies between zinc and util, and this is a 1-line 1-class jar that I think we should drop.

@dwijnand dwijnand merged commit 46e8b99 into sbt:1.x Jul 26, 2017
@dwijnand dwijnand deleted the drop-util-testing branch July 26, 2017 14:11
@dwijnand dwijnand mentioned this pull request Aug 4, 2017
Merged
@dwijnand dwijnand added this to the 1.0.1 milestone Oct 2, 2017
cunei pushed a commit to cunei/zinc that referenced this pull request Oct 25, 2017
@rickynils
Merge pull request sbt#328 from non/topic/better-seeds
2018cd8 
Improve the seed interface a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@jvican jvican jvican approved these changes

@Duhemm Duhemm Awaiting requested review from Duhemm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@dwijnand @jvican @eed3si9n