Skip to content

Fix the performance of extract used name#193

Merged
eed3si9n merged 2 commits intosbt:1.0from
eed3si9n:wip/extract_name
Nov 12, 2016
Merged

Fix the performance of extract used name#193
eed3si9n merged 2 commits intosbt:1.0from
eed3si9n:wip/extract_name

Conversation

@eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Nov 12, 2016

This is a replacement of #187

I kept the tests written by @wpopielarski, but significantly simplified the fix implementation.

-        t.original.foreach(traverse)
+        if (inspectedTypeTrees.add(t.original)) {
+          t.original.foreach(traverse)
+        }

@eed3si9n eed3si9n mentioned this pull request Nov 12, 2016
Closed
@wpopielarski
Copy link
Contributor

wpopielarski commented Nov 12, 2016

LGTM

@eed3si9n eed3si9n merged commit 72af4e8 into sbt:1.0 Nov 12, 2016
@eed3si9n eed3si9n deleted the wip/extract_name branch November 12, 2016 19:43
@eed3si9n eed3si9n mentioned this pull request Nov 23, 2016
Merged
eed3si9n added a commit that referenced this pull request Dec 9, 2016
@eed3si9n
Merge pull request #200 from eed3si9n/wip/extractusednames
86ded5b 
Apply #193 to 2.10 bridge
@jvican jvican mentioned this pull request Feb 7, 2017
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eed3si9n @wpopielarski