Skip to content

Make code generation -Yno-imports friendly#81

Merged
eed3si9n merged 1 commit intosbt:masterfrom
jedesah:topic/Yno-imports
Mar 13, 2016
Merged

Make code generation -Yno-imports friendly#81
eed3si9n merged 1 commit intosbt:masterfrom
jedesah:topic/Yno-imports

Conversation

@jedesah
Copy link
Copy Markdown
Contributor

@jedesah jedesah commented Mar 11, 2016

Problem

Code generated by sbt-buildinfo cannot be compiled along with the -Yno-imports scalac flag

Solution

Explicitly add scala.Predef._ since we always generate code containing a reference to String and fully qualify any reference that is not a part of scala.Predef._.

## Problem

Code generated by sbt-buildinfo cannot be compiled along with the `-Yno-imports` `scalac` flag

## Solution

Explicitly add `scala.Predef._` since we always generate code containing a reference to `String` and fully qualify any reference that is not a part of `scala.Predef._`.
@jedesah
Copy link
Copy Markdown
Contributor Author

jedesah commented Mar 11, 2016

Fixes #80.

@jedesah
Copy link
Copy Markdown
Contributor Author

jedesah commented Mar 12, 2016

@eed3si9n Wondering if you could have a quick look at this. I don't think it's a very long review and Quasar is blocked on a new release of sbt-buildinfo in order to upgrade to scala 2.11.8.

@eed3si9n
Copy link
Copy Markdown
Member

LGTM

eed3si9n added a commit that referenced this pull request Mar 13, 2016
Make code generation -Yno-imports friendly
@eed3si9n eed3si9n merged commit 7403c5d into sbt:master Mar 13, 2016
@eed3si9n
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants