Create a renderer to make final fields#140
Merged
eed3si9n merged 3 commits intosbt:masterfrom Oct 1, 2018
magneticflux-:feature/fix#127-add-final-modifier
Merged
Create a renderer to make final fields#140eed3si9n merged 3 commits intosbt:masterfrom magneticflux-:feature/fix#127-add-final-modifier
eed3si9n merged 3 commits intosbt:masterfrom
magneticflux-:feature/fix#127-add-final-modifier
Conversation
…scala and made each line have the "final" modifier so they can be used in annotations
eed3si9n
requested changes
Sep 25, 2018
| @@ -0,0 +1,88 @@ | |||
| package sbtbuildinfo | |||
|
|
|||
| private[sbtbuildinfo] case class ScalaFinalCaseObjectRenderer(options: Seq[BuildInfoOption], pkg: String, obj: String) extends ScalaRenderer { | |||
Member
There was a problem hiding this comment.
Could you add scripted test to see if this can be used? I don't know if you can with package private.
Contributor
Author
There was a problem hiding this comment.
Whoops, you're right!
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Does this look good?
eed3si9n
approved these changes
Oct 1, 2018
eed3si9n
added a commit
that referenced
this pull request
Aug 8, 2020
This is a rework of #140 Looking closely it doesn't look like `ScalaFinalCaseObjectRenderer` added in #140 is actually going to be useful since it just added `final` in front of all vals. This provides fix for #127 by generating [constant value definition](https://www.scala-lang.org/files/archive/spec/2.12/04-basic-declarations-and-definitions.html#value-declarations-and-definitions) for `Int`, `Long`, `Double`, `Boolean`, `Symbol`, and `String`. This allows the values to be used in annotation as the scripted test show. Note due to constant folding using this is not recommended for libraries.
eed3si9n
added a commit
that referenced
this pull request
Aug 9, 2020
This is a rework of #140 Looking closely it doesn't look like `ScalaFinalCaseObjectRenderer` added in #140 is actually going to be useful since it just added `final` in front of all vals. This provides fix for #127 by generating [constant value definition](https://www.scala-lang.org/files/archive/spec/2.12/04-basic-declarations-and-definitions.html#value-declarations-and-definitions) for `Int`, `Long`, `Double`, `Boolean`, `Symbol`, and `String`. This allows the values to be used in annotation as the scripted test show. Note due to constant folding using this is not recommended for libraries.
Member
|
FYI upon closer inspection of this PR, I don't think simply adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied ScalaCaseObjectRenderer.scala to ScalaFinalCaseObjectRenderer.scala and made each line have the "final" modifier so they can be used in annotations.
Closes #127