Implicit convert TaskKey with the macro!#119
Merged
eed3si9n merged 4 commits intosbt:masterfrom Mar 1, 2018
Merged
Conversation
eed3si9n
reviewed
Feb 28, 2018
Member
eed3si9n
left a comment
There was a problem hiding this comment.
So now the default semantics is shifted to in-graph?
If so I'd bump the second segment of the version.
Member
Author
|
sgtm. bumped the various versions. |
9e06354 to
c47a72b
Compare
eed3si9n
added a commit
that referenced
this pull request
Aug 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When discussing the design of new in task graph execution, in #114, we
completely didn't think of backing the existing TaskKey[A] to
BuildInfoKey.Entry[A] implicit conversion with the macro!
Fixes #117