[2.x] Reject java.nio.file.Path cached task output type#9032
Merged
eed3si9n merged 2 commits intosbt:developfrom Apr 6, 2026
Merged
[2.x] Reject java.nio.file.Path cached task output type#9032eed3si9n merged 2 commits intosbt:developfrom
eed3si9n merged 2 commits intosbt:developfrom
Conversation
**Problem** Like File, Path normally captures the absolute path, so likely not a good candidate for caching. **Solution** Ban it.
289733f to
5d9ca4a
Compare
xuwei-k
approved these changes
Apr 6, 2026
anatoliykmetyuk
approved these changes
Apr 6, 2026
Member
anatoliykmetyuk
left a comment
There was a problem hiding this comment.
LGTM, added a minor grammar point. Also would be good to add a test similar to sbt-app/src/sbt-test/cache/skip-file-cache.
core-macros/src/main/scala/sbt/internal/util/appmacro/Cont.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Anatolii Kmetiuk <anatoliikmt@proton.me>
eed3si9n
added a commit
to eed3si9n/sbt
that referenced
this pull request
Apr 7, 2026
**Problem** Like File, Path normally captures the absolute path, so likely not a good candidate for caching. **Solution** Ban it. --------- Co-authored-by: Anatolii Kmetiuk <anatoliikmt@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9014
Problem
Like File, Path normally captures the absolute path, so likely not a good candidate for caching.
Solution
Ban it.